Bug 573849 - Add autocomplete support to keywords field to allow easily population
Summary: Add autocomplete support to keywords field to allow easily population
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: User Interface
Version: devel
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: David Lawrence
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-15 21:49 UTC by David Lawrence
Modified: 2013-06-24 03:40 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-18 15:33:55 UTC
Embargoed:


Attachments (Terms of Use)
Patch to add autocomplete support to keywords text field (v1) (85.53 KB, patch)
2010-03-15 21:49 UTC, David Lawrence
no flags Details | Diff
Patch to add autocomplete support to keywords text field (v2) (85.98 KB, patch)
2010-03-17 18:58 UTC, David Lawrence
nelhawar: review+
Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Mozilla Foundation 455810 0 None None None Never

Description David Lawrence 2010-03-15 21:49:35 UTC
Created attachment 400309 [details]
Patch to add autocomplete support to keywords text field (v1)

Description of problem:
Currently the keywords field is not intuitive and users may not know what the choices are. This patch adds YUI autocomplete support to the keywords field
so that when a user selects the field they get a drop down menu of choices. When they click on a keyword from the menu, it is added to the text field automatically.

This is borrowed from an upstream bug that should be in a future release of Bugzilla by Guy Pyzak. 

https://bugzilla.mozilla.org/show_bug.cgi?id=455810

Dave

Comment 1 Noura El hawary 2010-03-16 12:40:54 UTC
Hi Dave,

I looked at the back on bz-web1 it looks really nice and works perfect only couple of things:

- the list items has bullet points maybe better to remove them
- The work 'false' always appears at the bottom of the list , not sure what is causing that.

other than than looks good to me.

Regards,
Noura

Comment 2 David Lawrence 2010-03-16 14:34:13 UTC
(In reply to comment #1)
> Hi Dave,
> 
> I looked at the back on bz-web1 it looks really nice and works perfect only
> couple of things:
> 
> - the list items has bullet points maybe better to remove them
> - The work 'false' always appears at the bottom of the list , not sure what is
> causing that.
> 
> other than than looks good to me.
> 
> Regards,
> Noura    

Hmm, there should not be any bullet points. The javascript/css should remove those and make the list look like a scrolling selection drop down. Did you do a full shift-reload to make sure all CSS and JS were reloaded from the server?

I also do not see the word "false" which may be happening for you due to the above also. Please do the shift-reload and see if it looks better.

Dave

Comment 3 Noura El hawary 2010-03-17 13:16:10 UTC
Hi Dave,

when trying to add the keywords in a new bug report enter_bug.cgi it works perfect, but still when trying to add them to an already existing bug report i still see the bullet points and the false word ever after shift+reload.

Noura

Comment 4 David Lawrence 2010-03-17 18:54:28 UTC
(In reply to comment #3)
> Hi Dave,
> 
> when trying to add the keywords in a new bug report enter_bug.cgi it works
> perfect, but still when trying to add them to an already existing bug report i
> still see the bullet points and the false word ever after shift+reload.
> 
> Noura    

Ah, figured out what I did wrong. I was not loading the stylesheet properly in bug/show.html.tmpl so it should be better now.

Dave

Comment 5 David Lawrence 2010-03-17 18:58:01 UTC
Created attachment 400858 [details]
Patch to add autocomplete support to keywords text field (v2)

New patch that properly loads the autocomplete.css stylesheet.

Dave

Comment 6 Noura El hawary 2010-03-18 02:53:26 UTC
Comment on attachment 400858 [details]
Patch to add autocomplete support to keywords text field (v2)

hey Dave,

Patch looks perfect now, and functions correctly in new reports and already existing bug reports.

Thanks,
Noura

Comment 7 David Lawrence 2010-03-18 15:33:55 UTC
Thanks Noura. Committed.


Note You need to log in before you can comment on or make changes to this bug.