Spec URL: https://fedorahosted.org/releases/b/e/beaker/beaker.spec SRPM URL: https://fedorahosted.org/releases/b/e/beaker/beaker-0.5.8-0.fc12.src.rpm Description: Beaker is an automated test system, it uses other open source technology where possible. cobbler for provisioning and beah for the harness on the test systems. Jobs are described in an xml language which the scheduler processes and finds systems that match.
First glimpses: - %define is used instead of %global - python-devel instead of python2-devel in BR - python_sitelib is not declared conditionally, it is already defined in F13+ iirc - /var/lib/cobbler/kickstarts/Fedoradevelopment.ks - Use %{_sharedstatedir} instead on Fedora and %{_var}/lib on EPEL, if you plan to support EPEL
Hello Till, Thanks for looking at this. Question about python_sitelib is not declard condtionally. I thought the below code was conditional. %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} !? should say if its not defined right? And for python-devel to python2-devel. Should All python be changed to python2-*? Thanks again.
Hello Till, Another question on macro sharedstatedir, it expands into the following on my F12 machine: %_sharedstatedir %{_prefix}/com That would not work since I need to put the kickstart files in the same directory that cobbler does and after looking at its spec file it still uses hard coded /var. I could change it to %{_var} or %{_localstatedir}. Would that be acceptable?
Hello Bill, (In reply to comment #2) > Question about python_sitelib is not declard condtionally. I thought the below > code was conditional. > > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib()")} > > !? should say if its not defined right? The guidelines currently add a condition on the Fedora release: %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif > And for python-devel to python2-devel. Should All python be changed to > python2-*? No, currently it should be only python2-devel For references, please take a look at the python packaging guidelines: http://fedoraproject.org/wiki/Packaging:Python (In reply to comment #3) > Another question on macro sharedstatedir, it expands into the following on my > F12 machine: > > %_sharedstatedir %{_prefix}/com Do you maybe have this defined in your ~/.rpmmacros? In EPEL 4 & 5, this happens, too. But it should not on F12 and does not happen on my F12 machines and I know of another package in Fedora that uses %_sharedstatedir and works for F11+, it's gitolite if you want to look at it.
There doesn't seem to have been any response to Till's comments above.