Spec URL: http://krishnan.cc/devel/repository/fedora/SPECS/abinit.spec SRPM URL: http://krishnan.cc/devel/repository/fedora/SRPMS/abinit-6.0.2-1.fc12.src.rpm Description: ABINIT is a package whose main program allows one to find the total energy, charge density and electronic structure of systems made of electrons and nuclei within Density Functional Theory, using pseudo-potentials and a plane-wave basis. Binary URL: http://krishnan.cc/devel/repository/fedora/RPMS/x86_64/abinit-6.0.2-1.fc12.x86_64.rpm Need sponsor.
Tested this with Fedora 12 (x86_64). Also 'rpmlint' did not report any major errors.
Be sure to go through the Fedora guidelines, most important of the which are http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Additionally to the Packaging Guidelines, there are a bunch of language / application specific guidelines that are linked to in the Packaging Guidelines. Here are some tricks of the trade: http://fedoraproject.org/wiki/Packaging_tricks http://fedoraproject.org/wiki/Packaging/ScriptletSnippets http://fedoraproject.org/wiki/Common_Rpmlint_issues
I did read all of those guidelines. Let me know if anyone finds any issues with the SPEC or the SRPM package.
The first issues that come to mind: - Explicit requires are banned by Packaging Guidelines - BuildRequires are missing. Need at least: BuildRequires: gcc-gfortran BuildRequires: lapack-devel - There are some other programs and libraries that are supported by abinit and are already in Fedora (for instance wannier90). Relevant buildrequires need to be added and the configure switches turned on. - Some thought could be put in packaging the supported addons that aren't yet in Fedora (for instance bigdft). - This program supports MPI, so the MPI versions should also be packaged (MPI guidelines). This part can be a bit rough, at least it is very likely to make the spec file very hard to read. ** What is your interest in packaging abinit? Do you use it yourself? Have you made any other submission yet?
Oh, and a few other things: - Get rid of commented lines that are empty. - Please don't use macros for standard commands. Even though rpm has macros such as %__mv, %__cp, %__make and so on, IMHO they just make the spec file harder to read. - Don't use %makeinstall, it's forbidden in the packaging guidelines. Use make install DESTDIR=%{buildroot} or make install DESTDIR=$RPM_BUILD_ROOT instead.
No response to commentary in months, and another ticket from the same submitter was closed due to lack of response. Closing this one as well.