Created attachment 407139 [details] proposed fix for /etc/init.d/iscsi Description of problem: There are two problems that I encountered, but is they are easy to fix I'm putting them under one bugzilla. 1/ initscripts /etc/init.d/iscsi and /etc/init.d/iscsid are not removing theirs .pid file which results in bad return codes (non-lsb compliant) and "Process dead but pid file exists" message on each starting of the service. (diff to illustrate the proposed fix: etc-init.d-iscsi.diff) 2/ start() in /etc/init.d/iscsi is using RETVAL variable which is used as general return value. It should be either renamed or declared local. ((diff to illustrate the proposed fix: etc-init.d-iscsid.diff) Version-Release number of selected component (if applicable): iscsi-initiator-utils-6.2.0.871-0.16.el5 How reproducible: always. Steps to Reproduce: 1. install iscsi-initiator-utils 2. service iscsi start 3. echo $? (issue 1) 4. service iscsi restart (issue 2) Actual results: Expected results: Additional info: # rpm -q --verify iscsi-initiator-utils # echo $? 0 # service iscsi status iscsid is stopped # service iscsi start iscsid is stopped Starting iSCSI daemon: [ OK ] [ OK ] Setting up iSCSI targets: iscsiadm: No records found! [ OK ] # echo $? <<<< issue 1 3 # service iscsi restart Stopping iSCSI daemon: iscsid dead but pid file exists [ OK ] <<<< issue 2 Starting iSCSI daemon: [ OK ] [ OK ] Setting up iSCSI targets: iscsiadm: No records found! [ OK ]
Created attachment 407141 [details] proposed fix for /etc/init.d/iscsid
Thanks Michal. This seems ok to me. Adding devel ack for 5.6.
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux.
This is fixed in iscsi-initiator-utils-6.2.0.872-2.el5. It can be downloaded here: http://people.redhat.com/mchristi/iscsi/rhel5.6/iscsi-initiator-utils/
Verified on RHEL5.6-Server-20101014.0
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: When the "stop" operation was invoked, the iscsid init script did not remove the process identifier (PID) file. This update modifies the iscsid script to remove the PID file during the stop operation.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0072.html