Bug 588793 - wvdial doesn't use liblockdev
Summary: wvdial doesn't use liblockdev
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: wvdial   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Ondrej Vasik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-04 14:40 UTC by Jiri Popelka
Modified: 2010-05-04 19:05 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-05-04 19:05:39 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Jiri Popelka 2010-05-04 14:40:07 UTC
from wvdial.spec:

BuildRequires: lockdev-devel

%build
make \
  CPPOPTS="$RPM_OPT_FLAGS -DUSE_LOCKDEV=1" \
  LOCKDEV=-llockdev \
  XX_LIBS="-lcrypt -llockdev" \


Changelog also says that wvdial uses lockdev for locking,
but I can't find any place where wvdial includes any liblockdev header (baudboy.h, ttylock.h, lockdev.h) or uses any liblockdev function.
The Makefile also doesn't know anything about LOCKDEV or USE_LOCKDEV variable.

If I'm wrong feel free to close this as notabug.
Otherwise remove the liblockdev bits from spec file.

Thanks

Comment 1 Ondrej Vasik 2010-05-04 19:05:39 UTC
Thanks for report, Jirko - however, it's really notabug - wvdial is very closely related to libwvstreams library ...

#include wvmodem.h in wvdial leads to #include wvlockdev.h ... and it uses USE_LOCKDEV in wvlockdev.cc ... 
Maybe strange, maybe really hidden, but it is there ... 

Closing...


Note You need to log in before you can comment on or make changes to this bug.