Bug 589453 - some nwfilter related functions missing in libvirt-python bindings
Summary: some nwfilter related functions missing in libvirt-python bindings
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Daniel Veillard
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Keywords:
: 589050 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-06 08:13 UTC by Gunannan Ren
Modified: 2014-06-18 07:18 UTC (History)
9 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-07-02 19:33:08 UTC


Attachments (Terms of Use)

Description Gunannan Ren 2010-05-06 08:13:21 UTC
Description of problem:
on the version libvirt-python-0.8.1-1.el6.x86_64
There are some functions not to be included in libvirt.py for nwfilter feature.
like nwfilterLookupByUUIDString, nwfilterDefineXML , nwfilter-undefined function
nwfilter-dumpxml function

Version-Release number of selected component (if applicable):

libvirt-python-0.8.1-1.el6.x86_64

How reproducible:

always

Steps to Reproduce:
1.look up the libvirt.py
2.
3.
  
Actual results:

lack of some nwfilter related functions

Expected results:

all nwfilter related functions exists

Additional info:

Comment 2 RHEL Product and Program Management 2010-05-06 09:36:06 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 4 Daniel Berrange 2010-05-11 10:53:46 UTC
This should be addressed by this commit that was in 0.8.1

commit f7366d84f4c83c50e79f3f24cc038e0a1c83374b
Author: Stefan Berger <stefanb@us.ibm.com>
Date:   Thu Apr 29 06:46:01 2010 -0400

    nwfilter: python bindings for nwfilter
    
    I have primarily followed the pattern of the 'secret' driver to provide
    support for the missing python bindings for the network filter API.



and in my GIT checkout everything is fine. It looks like the tar.gz of the 0.8.1 release of libvirt though included an outdated docs/libvirt-api.xml file and thus when the python bindings got built in brew, these APIs were not included. We need to find out why the libvirt-api.xml was not being re-generated correctly. Forcing regeneration in brew & rebuilding shoudl fix this.

Comment 5 Daniel Veillard 2010-05-11 13:27:56 UTC
Argh, that's the reason ... okay, will fix, thanks !

Daniel

Comment 6 Stefan Berger 2010-05-11 13:52:39 UTC
Confirmed that in 2nd build

libvirt-python-0.8.1-2.el6.x86_64

parts of the API are also missing and docs/libvirt-api.xml does not show
the nwfilter functions. The git checkout of tag v0.8.1 does show the functions in docs/libvirt-api.xml.

Comment 7 Daniel Veillard 2010-05-12 16:30:18 UTC
libvirt-0.8.1-3.el6 has been built in RHEL-6-candidate with the fix, it should
now export the nwfilter functions and snapshot ones from python bindings.

The problem is precisely that docs/libvirt-api.xml is not in git anymore
and the docs/Makefile.am was modified in subtle ways leading to it
not being rebuilt anymore on "make dist" like I'm used to.

Daniel

Comment 8 Stefan Berger 2010-05-14 18:38:51 UTC
I installed libvirt-0.8.1-3.el6 rpm and can confirm that the previously missing functions are now available in the python bindings.

Comment 9 Daniel Berrange 2010-05-18 16:53:10 UTC
*** Bug 589050 has been marked as a duplicate of this bug. ***

Comment 12 releng-rhel@redhat.com 2010-07-02 19:33:08 UTC
Red Hat Enterprise Linux Beta 2 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.