This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

I've put a test package with a fix for this problem at:

http://people.redhat.com/clalance/bz589864-bz591839/

Can you download it, install it, and try your test-case again?

Thanks,
Chris Lalancette

(In reply to comment #3)
Hi Chris,
I retested it with your given packages, but I met a error:
error: server closed connection: 
error: failed to connect to the hypervisor
Although I restart libvirtd service again, and I can correctly run 'virsh uri',
it still is failed when I define a domain from xml, I can see the above error information, which should be a "VIR_ERR_SYSTEM_ERROR". it seems that socket builds connection failed when running 'virsh' command again.Need I some privilege to connect the hypervisor for your given packages?

Steps to Reproduce:
[root@dhcp-66-70-62 ajia]# service libvirtd restart
Stopping libvirtd daemon:                                  [FAILED]
Starting libvirtd daemon:                                  [  OK  ]
[root@dhcp-66-70-62 ajia]# service libvirtd restart
Stopping libvirtd daemon:                                  [  OK  ]
Starting libvirtd daemon:                                  [  OK  ]
[root@dhcp-66-70-62 ajia]# virsh uri
qemu:///system

[root@dhcp-66-70-62 ajia]# virsh define rhel5u4-qcow2.xml 
error: server closed connection: 
error: failed to connect to the hypervisor

BTW, I can successfully define a domain from the rhel5u4-qcow2.xml with release packages of libvirt.

(In reply to comment #4)
> (In reply to comment #3)
> Hi Chris,
> I retested it with your given packages, but I met a error:
> error: server closed connection: 
> error: failed to connect to the hypervisor
> Although I restart libvirtd service again, and I can correctly run 'virsh uri',
> it still is failed when I define a domain from xml, I can see the above error
> information, which should be a "VIR_ERR_SYSTEM_ERROR". it seems that socket
> builds connection failed when running 'virsh' command again.Need I some
> privilege to connect the hypervisor for your given packages?

Yeah, there is some bug in the package I built for you, but I just can't figure out what it is at the moment.  Can you collect a corefile from the crashing libvirtd and upload it somewhere so I can take a look at it?  Alternatively if you give me access to your machine, I can log in and see what is going on myself (I'll need the IP address and password for the machine in that case).

Thanks,
Chris Lalancette

Hi Alex,
     I know you said you are busy for the rest of the week, so I'll just leave this comment and you can get back to it when you have time.  The problem with the original package I uploaded had to do with the way I built it.  I've now fixed the package and installed it onto your machine.  You can also download the fixed packages from:

http://people.redhat.com/clalance/bz589864-bz591839/

With that in place, I was able to successfully run the example you gave in your initial comment on a *shut-off* machine.  Doing a snapshot on a running machine won't work in RHEL-6 because the QMP support for savevm is missing, but that is a qemu bug and not a libvirt bug.

That being said, I would like for you to re-test this package again just to have independent verification.  Just let me know when you've had time to take a look again.

Thanks,
Chris Lalancette

(In reply to comment #6)
Chris,
I re-test this package using previous steps and can get snapshot object:
>>> snap = dom.snapshotLookupByName("snapshot1", 0)
>>> dir(snap)
['__del__', '__doc__', '__init__', '__module__', '_dom', '_o', 'delete', 'domain', 'getXMLDesc']
>>> snap.getXMLDesc(0)
'<domainsnapshot>\n  <name>snapshot1</name>\n  <description>hello snapshot</description>\n  <state>shutoff</state>\n  <creationTime>1274794486</creationTime>\n  <domain>\n    <uuid>daab6033-e29f-53a4-99e8-45c1a4df8881</uuid>\n  </domain>\n</domainsnapshot>\n'
>>> snap.domain().name()
'rhel5u4-qcow2'
>>> snap.delete(0)
0
>>> dom.snapshotListNames(0)
[]

so the issue has been fixed with libvirt-0.8.1-6bz589864bz591839.el6.x86_64
on REHL6.0-Beta.

(In reply to comment #7)
> (In reply to comment #6)
> Chris,
> I re-test this package using previous steps and can get snapshot object:
> >>> snap = dom.snapshotLookupByName("snapshot1", 0)
> >>> dir(snap)
> ['__del__', '__doc__', '__init__', '__module__', '_dom', '_o', 'delete',
> 'domain', 'getXMLDesc']
> >>> snap.getXMLDesc(0)
> '<domainsnapshot>\n  <name>snapshot1</name>\n  <description>hello
> snapshot</description>\n  <state>shutoff</state>\n 
> <creationTime>1274794486</creationTime>\n  <domain>\n   
> <uuid>daab6033-e29f-53a4-99e8-45c1a4df8881</uuid>\n 
> </domain>\n</domainsnapshot>\n'
> >>> snap.domain().name()
> 'rhel5u4-qcow2'
> >>> snap.delete(0)
> 0
> >>> dom.snapshotListNames(0)
> []
> 
> so the issue has been fixed with libvirt-0.8.1-6bz589864bz591839.el6.x86_64
> on REHL6.0-Beta.    

Great, thanks for the testing!  I'll get this patch posted.

Chris Lalancette

libvirt-0_8_1-8_el6 has been built in RHEL-6-candidate with the fix.

Dave

Verified.The python interface works fine in snapshot create and delete.

>>> for name in name_list:
...     print dom.snapshotLookupByName(name,0)
... 
<libvirt.virDomainSnapshot instance at 0x7fe2e99005a8>

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.