Bug 593333 - virt-manager: Fix automatic keymap resolution
Summary: virt-manager: Fix automatic keymap resolution
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virt-manager   
(Show other bugs)
Version: 6.0
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-18 14:39 UTC by Cole Robinson
Modified: 2010-11-10 21:53 UTC (History)
7 users (show)

Fixed In Version: virt-manager-0.8.4-7.el6
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-11-10 21:53:49 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Straight backport from upstream (2.07 KB, text/plain)
2010-05-18 15:00 UTC, Cole Robinson
no flags Details
Proper fix for VNC keymap issue (3.66 KB, text/plain)
2010-07-07 15:19 UTC, Cole Robinson
no flags Details

Description Cole Robinson 2010-05-18 14:39:07 UTC
QEMU and gtk-vnc in RHEL6 cooperate to transparently use the host keymap in the guest. However, virt-manager is incorrectly trying to guess the desired keymap, which overrides the qemu/gtk-vnc behavior.

This is fixed by the upstream commit:

http://hg.fedorahosted.org/hg/virt-manager/rev/7b09131ffffc

Before and after the patch, do the following:

- Create a guest with virt-manager.
- virsh dumpxml $vmname | grep keymap

Before the patch, there will be a keymap= returned
After the patch, no keymap will be specified.

FYI, if there is no keymap= value in the XML and the guest has messed up keymap, it isn't a virt-manager issue.

Comment 1 RHEL Product and Program Management 2010-05-18 14:55:23 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 2 Cole Robinson 2010-05-18 15:00:48 UTC
Created attachment 414882 [details]
Straight backport from upstream

Comment 3 Cole Robinson 2010-05-18 15:37:40 UTC
Fix built in virt-manager-0.8.4-3.el6

Comment 5 dyuan 2010-07-06 05:10:12 UTC
Test with virt-manager-0.8.4-6.el6, Create a guest with virt-manager, then virsh dumpxml $vmname | grep keymap, there is only a '<graphics type='vnc' port='5900' autoport='yes' keymap='en-us'/>' returned, and get the same testing result with **virt-manager-0.8.4-2.el6**.

Is that the expected result ?

Comment 6 Cole Robinson 2010-07-07 15:19:51 UTC
Created attachment 430092 [details]
Proper fix for VNC keymap issue

Good catch, the original patch only pulled one half of the default device model fixes. This patch now contains the important part.

Comment 7 Cole Robinson 2010-07-07 15:26:20 UTC
Proposing as a blocker: the additional change to fix this bug is small and low risk. Not fixing this in 5.0 will definitely yeild bug reports from users, since current behavior falls back to en-us keymap setting for most new virtual machines.

Comment 10 Cole Robinson 2010-07-13 20:25:40 UTC
Fix built in virt-manager-0.8.4-7.el6

Comment 12 yanbing du 2010-07-22 09:29:08 UTC
Verified with virt-manager-0.8.4-7.el6.
Create a guest with virt-manage, then virsh dumpxml $vmname | grep keymap, nothing returned.

Comment 13 min zhan 2010-09-13 06:06:46 UTC
Verified Passed with virt-manager-0.8.4-8.el6.noarch.

Comment 14 releng-rhel@redhat.com 2010-11-10 21:53:49 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.