Created attachment 417838 [details]
Screenshot 1 - First page of wizard for adding new storage pool
Description of problem:
Creation of dedicated local "disk" type storage pools with the storage pool wizard fails, if the disk in question has no disk label. (ie brand new or has been wiped)
Version-Release number of selected component (if applicable):
# rpm -qa | grep virt-manager
Steps to Reproduce:
1. Physically connect a new disk device to the host server.
2. Start the Virtual Machine Manager GUI on the host server, then open the host properties dialog and choose the Storage tab.
3. Create a new "disk" storage pool, specifying the newly attached disk, and specifying a format (ie "dos"). This is shown in screenshots 1 to 3.
The error occurs immediately upon pressing the Finish button, as virt-manager attempts to create the storage pool. Perhaps virt-manager isn't passing the options to libvirt correctly?
The Storage Pool is not created. Instead, an error message dialog appears (screenshot 4), claiming a disk format (ie "dos") must be specified, even though this was done. (see screenshot 2 as evidence of options passed)
Storage pool to be created and usable as per options given.
Even if a disk label is created on the newly attached disk prior to running the storage pool wizard, this (exact) error still occurs.
# parted /dev/sdb
GNU Parted 2.1
Welcome to GNU Parted! Type 'help' to view a list of commands.
New disk label type? msdos
Information: You may need to update /etc/fstab.
The only workaround this far to getting the pool created, is by unchecking the "Build Pool" checkbox in the wizard. This allows the storage pool wizard to finish, with the storage pool becoming available and "active" in the storage pools tab.
However, volumes created within this storage pool do not become visible until the virt-manager GUI is then restarted (another bug).
Created attachment 417839 [details]
Screenshot 2 - Second page of wizard for adding new storage pool. This one shows the Format option and the Build Pool checkbox.
Created attachment 417842 [details]
Screenshot 3 - Warning dialog showing that the device will be formatted. (this is not the error)
Created attachment 417843 [details]
Screenshot 4 - The error dialog showing the error.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release. Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release. This request is not yet committed for
Thanks for the report. The 'are you sure' prompt when selecting the 'build' option was conspiring behind the scenes to break pool creation. Trying to build a disk or LVM pool was broken. Fixed upstream now:
*** Bug 598359 has been marked as a duplicate of this bug. ***
Verified PASSED with virt-manager-0.8.4-6.el6.
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.