Spec URL: http://yyang.fedorapeople.org/maven2/maven-help-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-help-plugin-2.1.1-1.src.rpm Description: The Maven Help Plugin is used to get relative information about a project or the system. It can be used to get a description of a particular plugin, including the plugin's mojos with their parameters and component requirements,the effective POM and effective settings of the current build, and the profiles applied to the current project being built.
I'm taking this one.
Review: OK: rpmlint must be run on every package. Output: maven-help-plugin.noarch: W: spelling-error %description -l en_US plugin's -> plug in's, plug-in's, plugging maven-help-plugin.noarch: W: spelling-error %description -l en_US mojos -> moos, Mojaves, Mojave maven-help-plugin.noarch: W: no-documentation maven-help-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-help-plugin False positives. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Btw, there is no need to put both -Dmaven.test.skip=true and -Dmaven.test.failure.ignore=true . The first one do not run tests at all so the second has no effect. Otherwise package looks good. This package is APPROVED.
yyang, you have to set fedora-cvs to ? not to +
akurtako, thanks for your reminder, changed to ?
New Package CVS Request ======================= Package Name: maven-help-plugin Short Description: Plugin to get relative information about a project or the system Owners: yyang Branches: devel InitialCC: huwang liweinan akurtako dbhole
cvs done, except liweinan account doesn't exist.
Hi Kevin, cvs is not done yet after 12 hours passed, may be caused by wrong CC, please create cvs again and leave CC blank, thanks. New Package CVS Request ======================= Package Name: maven-help-plugin Short Description: Plugin to get relative information about a project or the system Owners: yyang Branches: devel InitialCC:
Try now. I think it's complete.
http://koji.fedoraproject.org/koji/buildinfo?buildID=177853