Bug 603267 - Review Request: Netperf - Benchmark tool for networking.
Review Request: Netperf - Benchmark tool for networking.
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2010-06-12 02:10 EDT by Gowrishankar Rajaiyan
Modified: 2012-06-29 18:26 EDT (History)
8 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-06-29 18:26:38 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Gowrishankar Rajaiyan 2010-06-12 02:10:20 EDT
Spec URL: http://gowrishankar.fedorapeople.org/spec/netperf.spec
SRPM URL: http://gowrishankar.fedorapeople.org/srpms/netperf-2.4.5-1.fc12.src.rpm

Description: Netperf is a benchmark that can be used to measure the performance
of many different types of networking. It provides tests for both
unidirectional throughput, and end-to-end latency. The environments
currently measurable by netperf include:

TCP and UDP via BSD Sockets for both IPv4 and IPv6
- Unix Domain Sockets
- SCTP for both IPv4 and IPv6
- Netperf is a benchmark used to measure the performance of networking.
Comment 1 Stanislav Ochotnicky 2010-07-01 09:13:24 EDT
Few notes:
 * use %configure macro, this will set proper paths automatically
 * either use "make %{?_smp_mflags}" or explain why parallel builds are not possible
 * why delete only README.windows and not others? Either delete/not install readme files for hpux/ovms/solaris/and the rest or install all of them without exceptions (the README.vmware~ is ok...obviously stale backup file)
 * you are missing %clean phase with rm -rf $RPM_BUILD_ROOT
 * netperf info file doesn't include INFO-DIR-SECTION therefore your post/preun scriptlets are moot (you also checked for existence of wrong file so they were never run). Either patch info/texi file to include proper dir section or do not even call install-info (btw normally it is better to Require "info" then "/sbin/install-info")
Comment 2 Gowrishankar Rajaiyan 2010-07-23 15:24:20 EDT
Hi Stanislav,

I appreciate and thank you for reviewing my spec.

here is the updated spec and srpm:

Comment 3 manuel wolfshant 2010-07-23 16:02:17 EDT
Keep in mind that "rm -rf $RPM_BUILD_ROOT" is mandatory only if you plan to build the packages for EPEL or Fedora older than F-13.
Comment 4 Jason Tibbitts 2010-11-22 13:58:42 EST
Actually you can dump the whole clean section for F13+ and EL6+.

It's useful (well, actually mandatory) to run rpmlint and look at the output:

  netperf.x86_64: W: wrong-file-end-of-line-encoding
Needs fixing, assume that there's any point at all in including this file.

  netperf.x86_64: E: info-files-without-install-info-postin
  netperf.x86_64: E: info-files-without-install-info-postun
You need to follow http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo if your package includes texinfo documentation.
Comment 5 Rafael Aquini 2010-11-23 18:17:58 EST
Hello Gowrishankar,

Are you still interested in getting netperf into Fedora packages? If yes, please consider Jason observations and submit a new bumped-release .spec & srpm.

Do you have a FAS account? 

As I couldn't find your email in Fedora Packager CVS Commit Group (packager), I have assumed you do not have an account, and you must get one before you proceed:

Also, if this is your first package review request, you gonna need a member sponsorship in order to check in and build your package, after get your work reviewed.

I'll be glad in helping you out.

Best regards


Note You need to log in before you can comment on or make changes to this bug.