Red Hat Bugzilla – Bug 604972
inventory allows reservation of an already reserved machine
Last modified: 2015-05-03 22:09:23 EDT
Description of problem:
Please see the history for dell-pesc1420-01.rhts.eng.bos.redhat.com
at 2010-06-16 13:04:11 the system got reserved by mbanas, but at 2010-06-16 13:04:12 I got the system, and I was able to start provisioning, but then the machine was "stolen" from me because of the earlier reservation
Version-Release number of selected component (if applicable):
Version - 0.5.43
Raising severity - this looks like a serious problem that could lead to hours of lost work. Also proposing for beaker_blocker - it is not a regression pre se, but an unreliable machine reservation is IMHO serious enough to stop us from switching from RHTS.
Please look into this. Thanks.
Hint: This will not steal machine already reserved for some time as this only happens when machines are reserved concurrently - notice the small time interval within which this happened. Looks more like a transaction lock is missing somewhere: concurrent threads/processes runs as follows:
1. check the machine is available
2. check the machine is available
1. reserve the machine
2. reserve the machine
Ok, I found the code for manual reservation and indeed there is a chance that it can happen. Should be easy to fix.
Fixed in git. Will go out in Tomorrows upgrade.