RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 607086 - RFE: change layout of image deletion window
Summary: RFE: change layout of image deletion window
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virt-manager
Version: 6.1
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-23 07:41 UTC by Jes Sorensen
Modified: 2010-06-23 13:39 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-23 13:39:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jes Sorensen 2010-06-23 07:41:39 UTC
Description of problem:
When deleting a virt image using virt-manager, it pops up a window where one has to say 'delete' or 'cancel', with a small checkbox one can check if the actual image is to be deleted, not just the XML data.

I deleted multiple images without noticing this checkbox and I was about to file a bug against it when I discovered it in my last test.

Since deleting the image file is a very common case, IMHO it would make more sense to change the three main click buttons to 'Delete Virt Machine' 'Delete Virt Machine and Image' 'Cancel'. That way users will actually notice it and not end up with 17 data images in /var/lib/libvirt/images that they thought were gone.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 RHEL Program Management 2010-06-23 08:07:38 UTC
This feature request did not get resolved in time for Feature Freeze
for the current Red Hat Enterprise Linux release and has now been
denied. It has been proposed for the next Red Hat Enterprise Linux
release. If you would still like it considered for the current
release as an exception, please make that request with your support
representative.

Comment 3 Cole Robinson 2010-06-23 13:39:52 UTC
(In reply to comment #0)
> Description of problem:
> When deleting a virt image using virt-manager, it pops up a window where one
> has to say 'delete' or 'cancel', with a small checkbox one can check if the
> actual image is to be deleted, not just the XML data.
> 
> I deleted multiple images without noticing this checkbox and I was about to
> file a bug against it when I discovered it in my last test.
> 
> Since deleting the image file is a very common case, IMHO it would make more
> sense to change the three main click buttons to 'Delete Virt Machine' 'Delete
> Virt Machine and Image' 'Cancel'. That way users will actually notice it and
> not end up with 17 data images in /var/lib/libvirt/images that they thought
> were gone.
> 

I don't think adding a separate button is the way to go. It has a few downsides:

1) User might accidentally hit the wrong button and remove an image they wanted to keep. This is a big fear, UI that might cause accidental data loss.

2) Removing the check box would require the storage list to always be sensitive (not greyed out). This would scare users who didn't want to remove VM storage: they might spend unnecessary time unchecking all storage options, only to realize the choice is also dictated by the bottom buttons. If you meant dropping the storage list altogether, I also disagree: the dialog can't be a simple choice of 'delete with image' vs 'delete' if the guest has multiple images attached, including physical partitions and CDROM media, etc. The user needs proper feedback here about what exactly we are removing.

3) Not sure why we should expect users to evaluate the content of all dialog buttons if they can't be expected to evaluate the primary content of the dialog (storage list and the check box).

4) Original UI had approval from a proper UI designer.

Also, the concerns about '17 data images' aren't as likely as you probably expect. Developers are probably using the 'delete' functionality most often, and they will often be kicking off a guest with the same name each time (as you were doing with virt-install). If creating this VM via virt-manager, we are smart enough to try and use an abandoned disk image with the expected name, so we don't pollute the host system with multiple disk images.

So closing this as NOTABUG


Note You need to log in before you can comment on or make changes to this bug.