Red Hat Bugzilla – Bug 610231
Missing initscript, superfluous .rej files, etc.
Last modified: 2016-04-19 22:14:45 EDT
Description of problem:
The packaging quality of conntrack-tools package is substandard:
1) despite containing a daemon (conntrackd), it does not provide its initscript.
2) the /etc/conntrackd directory needed by conntrackd by default is not present in the package
3) the %doc directory contains several .rej and .orig files, apparently from failed patching
4) I would suggest to add the /etc/conntrackd/conntrackd.conf file (possibly from sync/ftfw), and definitely mark it as %config, maybe missingok.
Version-Release number of selected component (if applicable):
Agreed. Some ideas...
The file /usr/share/doc/conntrack-tools-0.9.13/doc/debian.conntrackd.init.d could probably be fedorafied, tested and installed in /etc/init.d.
The junk in %doc is gone in 0.9.14 which was released last year and now appears in rawhide. Why not push to koji for f13?
0.9.14 also fixes the annoying cosmetic bug where usage() outputs gunk instead of trailing newline.
Has anybody done this? If it exists, I'd love to avoid rewriting the init script.
Created attachment 488199 [details]
Init script for conntrackd
Init script for conntrackd. Free to use under the terms of the GPL 2 or any later version.
Created attachment 488200 [details]
Sysconfig file that goes with init script
Sysconfig file for init script for conntrackd. Free to use under the terms of the GPL 2 or any later version.
Attached are an init script and sysconfig file for conntrackd. Let me know of any issues, it's my first.
If nobody is interested, I can commit this later this week and roll a new release. I think this is probably a good idea, and I'm pretty sure any subsequent package review would pick up the lack of a suitable init script. Yell if anyone has any problems. Thanks.
I have updated the base to 1.0.0 - just haven't built it yet. If you want you can add the scripts or I will add them myself. Thanks
(In reply to comment #8)
> I have updated the base to 1.0.0 - just haven't built it yet. If you want you
> can add the scripts or I will add them myself. Thanks
If you are prepping a new build, then please add them for me. I'm horribly hung over today and can't be trusted. Thanks dude.
RE: ping, I'd like to see this maintained in distros, in RHEL, etc... If there's something I should do, let me know. If there are bugs in my init scripts, I'm happy to patch them.
Paul: If you have this built and packaged (rpm), I'd be happy to test it.
Paul P Komkoff Jr : need help with this? I can co-maintain?
Sorry I let this slip. I have added the initscript and systconfig template, but I wanted to add systemd service and then got distracted :)
I'll try to add everything in next few days, but in any case I welcome co-maintainers.
Paul P Komkoff Jr: I'm happy to help out with at least testing in the future...
I think this is an awesome daemon, however I'm not sure why it doesn't get more love that I feel it should... Is everyone using something different and keeping it secret ? Thanks!
Created attachment 582819 [details]
Patch to upgrade, add systemd files, fixup spec file
I'm still waiting on commit access, but attached is the patch to bring this up to 1.0.1 including the systemd
commit access went through, so build should appear at:
Koji seems to have failed. I can't see the build.log but I'm pretty sure I have the fixes (based on previous experience compiling this). I can get them from my other machine tomorrow. (Small patches)
PS: Will finishing all this get conntrackd included in mainline rhel6?
Needed a small patch, so build is now in http://koji.fedoraproject.org/koji/taskinfo?taskID=4061862
Yes, I will go hunt down the original review bug and request a branch for EL6
Paul Wouters: thanks for following up on this. This is some great software which just needs some extra love :)
When the [S]RPM's are done, let me know and I'll put them in my test [TODO] queue.
Note that this requires systemd, so for the EL6 version, I need to update/create the init script.
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.
(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)
More information and reason for this action is here:
This message is a notice that Fedora 19 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 19. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 19 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
Thank you for reporting this bug and we are sorry it could not be fixed.