Bug 614356 - cluster.rng does not validate the cman_label attribute
Summary: cluster.rng does not validate the cman_label attribute
Alias: None
Product: Fedora
Classification: Fedora
Component: cluster   
(Show other bugs)
Version: 13
Hardware: All Linux
Target Milestone: ---
Assignee: Lon Hohberger
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 615509
TreeView+ depends on / blocked
Reported: 2010-07-14 08:59 UTC by Federico Simoncelli
Modified: 2010-09-30 20:27 UTC (History)
8 users (show)

Fixed In Version: cluster-3.0.14-1.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 615509 (view as bug list)
Last Closed: 2010-09-30 20:27:44 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

Description Federico Simoncelli 2010-07-14 08:59:31 UTC
Description of problem:
According to qdisk manual (and qdiskd source code) it is possible to configure the cman_label attribute for the quorumd element:

  This overrides the label advertised to CMAN if present.

Although it can not be validated against cluster.rng:

# grep quorumd cluster.conf
<quorumd cman_label="mylabel" interval="1" label="mylabel" tko="4" votes="1"/>

# xmllint -relaxng /usr/share/cluster/cluster.rng cluster.conf > /dev/null 
Relax-NG validity error : Extra element quorumd in interleave
/etc/cluster/cluster.conf:5: element quorumd: Relax-NG validity error : Element cluster failed to validate content
/etc/cluster/cluster.conf fails to validate

Version-Release number of selected component (if applicable):
# rpm -qf /usr/share/cluster/cluster.rng

Steps to Reproduce:
1. configure cluster.conf with quorum device and the cman_label attribute
2. update the cluster configuration
Actual results:
cluster.conf validation fails

Expected results:
cluster.conf validation should succeed and be updated

Additional info:
This patch should fix the issue:

--- /usr/share/cluster/cluster.rng.orig	2010-05-26 06:51:44.000000000 +0200
+++ /usr/share/cluster/cluster.rng	2010-07-14 10:15:07.000000000 +0200
@@ -280,6 +280,9 @@
         where the quorum device name differs among nodes." rha:sample=""/>
+    <attribute name="cman_label" rha:description="" rha:sample=""/>
+   </optional>
+   <optional>
     <attribute name="status_file" rha:description="" rha:sample=""/>

Note You need to log in before you can comment on or make changes to this bug.