RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 615509 - cluster.rng does not validate the cman_label attribute
Summary: cluster.rng does not validate the cman_label attribute
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: cluster
Version: 6.0
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Lon Hohberger
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On: 614356
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-16 21:17 UTC by Lon Hohberger
Modified: 2010-11-10 19:59 UTC (History)
14 users (show)

Fixed In Version: cluster-3.0.12-14.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 614356
Environment:
Last Closed: 2010-11-10 19:59:57 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Test case. (1.01 KB, text/plain)
2010-07-16 21:26 UTC, Lon Hohberger 		no flags Details
View All

Description Lon Hohberger 2010-07-16 21:17:39 UTC 
+++ This bug was initially created as a clone of Bug #614356 +++

Description of problem:
According to qdisk manual (and qdiskd source code) it is possible to configure the cman_label attribute for the quorumd element:

cman_label="mylabel"
  This overrides the label advertised to CMAN if present.

Although it can not be validated against cluster.rng:

# grep quorumd cluster.conf
<quorumd cman_label="mylabel" interval="1" label="mylabel" tko="4" votes="1"/>

# xmllint -relaxng /usr/share/cluster/cluster.rng cluster.conf > /dev/null 
Relax-NG validity error : Extra element quorumd in interleave
/etc/cluster/cluster.conf:5: element quorumd: Relax-NG validity error : Element cluster failed to validate content
/etc/cluster/cluster.conf fails to validate

Version-Release number of selected component (if applicable):
# rpm -qf /usr/share/cluster/cluster.rng
cman-3.0.12-2.fc13.x86_64

Steps to Reproduce:
1. configure cluster.conf with quorum device and the cman_label attribute
2. update the cluster configuration
  
Actual results:
cluster.conf validation fails

Expected results:
cluster.conf validation should succeed and be updated

Additional info:
This patch should fix the issue:

--- /usr/share/cluster/cluster.rng.orig	2010-05-26 06:51:44.000000000 +0200
+++ /usr/share/cluster/cluster.rng	2010-07-14 10:15:07.000000000 +0200
@@ -280,6 +280,9 @@
         where the quorum device name differs among nodes." rha:sample=""/>
    </optional>
    <optional>
+    <attribute name="cman_label" rha:description="" rha:sample=""/>
+   </optional>
+   <optional>
     <attribute name="status_file" rha:description="" rha:sample=""/>
    </optional>
    <optional>
Comment 1 Lon Hohberger 2010-07-16 21:26:32 UTC 
Created attachment 432507 [details]
Test case.
Comment 2 Lon Hohberger 2010-07-16 21:27:53 UTC 
[lhh@localhost xml]$ ~/cman_label_test.sh ./cluster.rng.in 
testing against ./cluster.rng.in
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS
Comment 4 Lon Hohberger 2010-07-19 13:37:59 UTC 
http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=7c4cb96ae94033d2608b65f56e705b2280fcfbaf
http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=0a884cdb93b9751598fb6e91598ee9c3c4132fb5
Comment 7 Dean Jansa 2010-08-24 14:58:27 UTC 
[root@marathon-01 ~]# /tmp/432507
testing against /usr/share/cluster/cluster.rng
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS


Verified using supplied test, thanks Lon!
Comment 8 releng-rhel@redhat.com 2010-11-10 19:59:57 UTC 
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.
Note You need to log in before you can comment on or make changes to this bug.