Bug 615509 - cluster.rng does not validate the cman_label attribute
Summary: cluster.rng does not validate the cman_label attribute
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: cluster
Version: 6.0
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: Lon Hohberger
QA Contact: Cluster QE
Depends On: 614356
TreeView+ depends on / blocked
Reported: 2010-07-16 21:17 UTC by Lon Hohberger
Modified: 2010-11-10 19:59 UTC (History)
14 users (show)

Clone Of: 614356
Last Closed: 2010-11-10 19:59:57 UTC

Attachments (Terms of Use)
Test case. (1.01 KB, text/plain)
2010-07-16 21:26 UTC, Lon Hohberger
no flags Details

Description Lon Hohberger 2010-07-16 21:17:39 UTC
+++ This bug was initially created as a clone of Bug #614356 +++

Description of problem:
According to qdisk manual (and qdiskd source code) it is possible to configure the cman_label attribute for the quorumd element:

  This overrides the label advertised to CMAN if present.

Although it can not be validated against cluster.rng:

# grep quorumd cluster.conf
<quorumd cman_label="mylabel" interval="1" label="mylabel" tko="4" votes="1"/>

# xmllint -relaxng /usr/share/cluster/cluster.rng cluster.conf > /dev/null 
Relax-NG validity error : Extra element quorumd in interleave
/etc/cluster/cluster.conf:5: element quorumd: Relax-NG validity error : Element cluster failed to validate content
/etc/cluster/cluster.conf fails to validate

Version-Release number of selected component (if applicable):
# rpm -qf /usr/share/cluster/cluster.rng

Steps to Reproduce:
1. configure cluster.conf with quorum device and the cman_label attribute
2. update the cluster configuration
Actual results:
cluster.conf validation fails

Expected results:
cluster.conf validation should succeed and be updated

Additional info:
This patch should fix the issue:

--- /usr/share/cluster/cluster.rng.orig	2010-05-26 06:51:44.000000000 +0200
+++ /usr/share/cluster/cluster.rng	2010-07-14 10:15:07.000000000 +0200
@@ -280,6 +280,9 @@
         where the quorum device name differs among nodes." rha:sample=""/>
+    <attribute name="cman_label" rha:description="" rha:sample=""/>
+   </optional>
+   <optional>
     <attribute name="status_file" rha:description="" rha:sample=""/>

Comment 1 Lon Hohberger 2010-07-16 21:26:32 UTC
Created attachment 432507 [details]
Test case.

Comment 2 Lon Hohberger 2010-07-16 21:27:53 UTC
[lhh@localhost xml]$ ~/cman_label_test.sh ./cluster.rng.in 
testing against ./cluster.rng.in
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS

Comment 7 Dean Jansa 2010-08-24 14:58:27 UTC
[root@marathon-01 ~]# /tmp/432507
testing against /usr/share/cluster/cluster.rng
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS

Verified using supplied test, thanks Lon!

Comment 8 releng-rhel@redhat.com 2010-11-10 19:59:57 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.

Note You need to log in before you can comment on or make changes to this bug.