Bug 615609 - Fedora's custom MANIFEST.MF in lucene drops "Specification-Version"
Summary: Fedora's custom MANIFEST.MF in lucene drops "Specification-Version"
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: lucene
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Deepak Bhole
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-17 12:30 UTC by Caolan McNamara
Modified: 2010-10-01 12:01 UTC (History)
1 user (show)

Fixed In Version: lucene-2.4.1-5.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-01 08:10:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
better way to do that (1.93 KB, patch)
2010-09-30 10:11 UTC, David Tardon
no flags Details | Diff
join broken lines (2.09 KB, patch)
2010-10-01 11:46 UTC, David Tardon
no flags Details | Diff

Description Caolan McNamara 2010-07-17 12:30:46 UTC
The OpenOffice.org configure test wants to check the version of lucene to make sure it's compatible. "vanilla" lucene comes with a MANIFEST.MF with a Specification-Version line which is used for the test. The Fedora lucene overwrites the MANIFEST with another one. Debian on the other hand apparently appends the desired extra information, e.g. http://www.mail-archive.com/pkg-java-maintainers@lists.alioth.debian.org/msg18631.html 

Can we restore the Specification-Version line back to lucene's MANIFEST.MF ?

Comment 1 Bug Zapper 2010-07-30 12:38:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 David Tardon 2010-09-30 10:11:16 UTC
Created attachment 450707 [details]
better way to do that

The attached patch appends the additional metadata keys to the original ones, instead of overwriting them.

Comment 3 Caolan McNamara 2010-09-30 10:18:45 UTC
caolanm->dbhole: Do you have any objections to this approach ? We'd like to stick this into rawhide to allow us to drop our build workarounds from our own packages.

Comment 4 Deepak Bhole 2010-09-30 21:34:47 UTC
David's proposed change keeps the OSGi meta-data, which is what matters to Eclipse. I have no objection to the proposed solution.

Comment 5 Caolan McNamara 2010-10-01 08:10:51 UTC
Done as lucene-2.4.1-4.fc15

Comment 6 David Tardon 2010-10-01 11:46:49 UTC
Created attachment 450986 [details]
join broken lines

The lines in the additional manifest files are wrapped at column 71, which causes problems now (InvalidManifestException or something like that, I didn't write it down). It's interesting that it worked before... Anyway, this additional patch rejoins the broken lines.

Comment 7 Caolan McNamara 2010-10-01 12:01:33 UTC
lucene-2.4.1-5.fc15 works, removed the blank lines instead


Note You need to log in before you can comment on or make changes to this bug.