Red Hat Bugzilla – Bug 616355
[RFE] Add configurable grab key sequences for VMM
Last modified: 2014-02-02 17:37:54 EST
Description of problem:
Since Gtk-Vnc release 0.4.0 (since git commit 378721ec1) the new API for configurable key grab sequences has been added. Users of virt-manager may want to change their grab key sequence since they may be using the default key combination for some other purpose, e.g. set to switching the window manager windows.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Grab keys are not configurable at the moment and they're pre-set to default Ctrl + Alt key combination.
When adding this feature user will be able to configure grab keys in the virt-manager preferences box. This should be saved in the plain text form (as it's show in window title when you have the grabbing active) somewhere in GConf configuration to make virt-manager remember it for the next run.
Created attachment 437674 [details]
Patch to add configurable grab key combination to VMM
this is the patch to add configurable grab keys combination I did in my spare time (originally for my own purposes). It requires at least GtkVNC 0.4.0 with the support for configuring the grab keys.
Created attachment 437855 [details]
New version of my patch including the exception handling for older version of Gtk-VNC
this is the new version of the patch including the exception handling when used with the old version of Gtk-VNC (pre-commit 378721ec1) that doesn't support the configurable grab keys.
Created attachment 440678 [details]
Support GTK-VNC configurable grab key combination
This is the new version of the patch with some improvements and changes.
Differences between version 1 and version 2 (this one):
- Implement the grab_keys_supported() method to check for configurable
grab keys support in the GTK-VNC version currently installed
- Grab key sequence is configurable in Prefs-> VM Details and "Change"
button is disabled when GTK-VNC doesn't support it - tooltip is being shown
- Exception handling when somebody manually edited the grab-keys in
GConf has been added to ignore invalid (non-integer) key codes
In rawhide now.