RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 617163 - cman dispatches config changes when there is no new config
Summary: cman dispatches config changes when there is no new config
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: cluster
Version: 6.0
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Fabio Massimo Di Nitto
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-22 11:17 UTC by Fabio Massimo Di Nitto
Modified: 2010-11-10 20:00 UTC (History)
7 users (show)

Fixed In Version: cluster-3.0.12-18.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-10 20:00:03 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Drop version -r#; always use version from cluster.conf (2.69 KB, patch)
2010-07-22 15:17 UTC, Lon Hohberger 		no flags Details | Diff
View All

Description Fabio Massimo Di Nitto 2010-07-22 11:17:44 UTC 
when issuing cman_tool version -rX, a new configuration is loaded and a configuration change is dispatched to all daemons to reload the new config.

In case where: cluster.conf is set to value X and cman_tool version -rX+1 (that is NOT available in the cluster), cman will still dispatch a new config notification. this should not happen till X+1 is loaded.
Comment 1 Lon Hohberger 2010-07-22 13:47:33 UTC 
Maybe we just add 'cman_tool configupdate' alias for 'cman_tool version -r0' ?

-r0 == Use what's in cluster.conf
Comment 2 Lon Hohberger 2010-07-22 14:01:06 UTC 
Or...

cman_tool version -r  = reload config (e.g. -r0)
cman_tool version -rX = reload config, print warning that the 'X'
                        is deprecated and is ignored
Comment 9 Lon Hohberger 2010-07-22 15:17:32 UTC 
Created attachment 433731 [details]
Drop version -r#; always use version from cluster.conf
Comment 10 Lon Hohberger 2010-07-22 15:18:31 UTC 
Note that this patch maintains cmdline compatibility except for the warning message.
Comment 11 Lon Hohberger 2010-07-22 15:22:31 UTC 
Due to the way getopt() works (shifting args around), it's difficult to catch this case in a sane way:

   cman_tool version -r -Dnone 123

This produces the warning about -r# deprecated (instead of an error in parsing the cmdline) but I don't really consider this a big issue.

The :: operator means an option arg might have an option, but requires:

   "-oopt"

That is, "-o opt" does not work with the getopt GNU extension for optional arguments.  Now, the ':' (required arg) option by contrast accepts both "-oopt" and "-o opt".

Consequently, the patch checks for both uses.  The alternative is to turn of opterr, which is not a good idea in my opinion.
Comment 13 Fabio Massimo Di Nitto 2010-07-26 13:14:23 UTC 
http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=ea01b37babe400a1f4545bd65e89d0ee6b35880e
Comment 14 Fabio Massimo Di Nitto 2010-07-27 08:50:56 UTC 
Note for QE: the test cases for those fixes are complex. I´ll need to prepare a proper document comparing before and after the fix.

Both Lon and I did test the fixes so I have built for Snap9. Stay tuned.
Comment 17 Dean Jansa 2010-08-24 14:56:26 UTC 
Verified while testing 617161.
Comment 18 releng-rhel@redhat.com 2010-11-10 20:00:03 UTC 
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.
Note You need to log in before you can comment on or make changes to this bug.