Bug 621543 - single broken plugin may render whole application useless
Summary: single broken plugin may render whole application useless
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kobo
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daniel Mach
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-05 12:51 UTC by Marian Csontos
Modified: 2013-01-02 12:52 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2013-01-02 12:52:23 UTC


Attachments (Terms of Use)
naive and untested patch (1.44 KB, patch)
2010-08-05 12:51 UTC, Marian Csontos
no flags Details | Diff

Description Marian Csontos 2010-08-05 12:51:09 UTC
Created attachment 436835 [details]
naive and untested patch

Description of problem:

When using register_module, single broken plugin in module's directory will reject all plugins in that dir.

Though this could be handled on higher level, IMO it is against plugin philosophy and plugins should be handled more separately: single misbehaving plugin should not render other plugins useless.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. 
2.
3.
  
Actual results:
- command line does not run

Expected results:
- warning is issued but commands provided by other plusing should still work

Additional info:
- https://bugzilla.redhat.com/show_bug.cgi?id=621522
- see beaker-client-0.5.52-1

Comment 1 Daniel Mach 2011-02-22 15:12:18 UTC
http://git.fedorahosted.org/git/?p=kobo.git;a=commit;h=26dfec404d90c4f416e9c28d23936080cc150673

Hopefully a better patch than yours :)
Add skip_broken to register_module() to enable this feature.

Comment 2 Marian Csontos 2011-02-22 20:33:22 UTC
Looks good. Thanks.


Note You need to log in before you can comment on or make changes to this bug.