Bug 624434 - Review Request: UFW - Uncomplicated Firewall
Summary: Review Request: UFW - Uncomplicated Firewall
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: StalledSubmitter, Almost a year and n...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-16 13:06 UTC by David Nussio
Modified: 2011-08-01 03:41 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-01 03:27:24 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Nussio 2010-08-16 13:06:45 UTC
Spec URL: http://ubuntuone.com/p/CtV/
SRPM URL: http://ubuntuone.com/p/CtU/
Description: 
Uncomplicated and easy to use CLI tool for managing a netfilter firewall

This is my first package and I am seeking a sponsor!

Koji build result:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2403658


RPM Lint result:
david@statix SPECS $ rpmlint ufw.spec ../SRPMS/ufw-0.29.3-1.fc13.src.rpm ../RPMS/noarch/ufw-0.29.3-1.fc13.noarch.rpm 
ufw.spec:65: W: libdir-macro-in-noarch-package (main package) %{_libdir}/%{name}/%{name}-*
ufw.spec:66: W: libdir-macro-in-noarch-package (main package) %config(noreplace) %{_libdir}/%{name}/user*.rules
ufw.src: W: spelling-error Summary(en_US) netfilter -> net filter, net-filter, refilter
ufw.src: W: spelling-error %description -l en_US netfilter -> net filter, net-filter, refilter
ufw.src: W: strange-permission ufw.init 0755L
ufw.src:65: W: libdir-macro-in-noarch-package (main package) %{_libdir}/%{name}/%{name}-*
ufw.src:66: W: libdir-macro-in-noarch-package (main package) %config(noreplace) %{_libdir}/%{name}/user*.rules
ufw.noarch: W: spelling-error Summary(en_US) netfilter -> net filter, net-filter, refilter
ufw.noarch: W: spelling-error %description -l en_US netfilter -> net filter, net-filter, refilter
ufw.noarch: W: non-etc-or-var-file-marked-as-conffile /lib/ufw/user.rules
ufw.noarch: W: non-etc-or-var-file-marked-as-conffile /lib/ufw/user6.rules
ufw.noarch: E: executable-sourced-script /etc/bash_completion.d/ufw 0755L
ufw.noarch: E: non-readable /etc/ufw/before6.rules 0640L
ufw.noarch: E: non-readable /etc/ufw/before.rules 0640L
ufw.noarch: E: non-readable /lib/ufw/user.rules 0640L
ufw.noarch: E: non-readable /etc/ufw/after.rules 0640L
ufw.noarch: E: non-readable /etc/ufw/after6.rules 0640L
ufw.noarch: E: non-readable /lib/ufw/user6.rules 0640L
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/ar.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/bg.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/ca.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/cs.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/da.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/de.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/el.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/en_AU.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/en_GB.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/fi.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/fr.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/he.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/hu.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/id.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/it.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/nb.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/nl.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/pl.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/pt.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/pt_BR.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/ru.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/sk.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/sl.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/sr.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/sv.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/tl.mo
ufw.noarch: W: file-not-in-%lang /usr/share/ufw/messages/zh_CN.mo
ufw.noarch: W: service-default-enabled /etc/rc.d/init.d/ufw
ufw.noarch: W: service-default-enabled /etc/rc.d/init.d/ufw
ufw.noarch: E: subsys-not-used /etc/rc.d/init.d/ufw
2 packages and 1 specfiles checked; 8 errors, 40 warnings.

Comment 1 Jochen Schmitt 2010-08-16 18:55:27 UTC
Hallo,

at first, it's nice, that your are trying to become a Fedora contributor. Unfortunately, the rpmlint output you have posted contains several issues which block a review of your package.

1.) On a noarch package you should use %{_prefix}/lib instead of %{_libdir}

2.) You should investigate work to fix your file permissions on your package. You can use the rpmls command from the rpmdevtools package to view the filepermission of the packaged files without installing your package.

3.) you should read

https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

because you seems to have an issue of handling of the locales of your package.

4.) you should inverstigate some work into your init scripts. Unfortunately there is a plan to convert to systemd on F-14. Because, I not a specialist about systemd, you may ask on devel.org for further assistance.

Best Regards:

Jochen Schmitt

Comment 2 Jason Tibbitts 2010-12-02 15:26:22 UTC
This package needs a lot of work, and there was never any response to Jochen's comments above.  Do you still wish to submit this package?

Comment 3 Nathan Owe 2011-08-01 03:41:27 UTC
No response in over a year


Note You need to log in before you can comment on or make changes to this bug.