Bug 630096 - fix coverity Defect Type: Error handling issues
Summary: fix coverity Defect Type: Error handling issues
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: 389
Classification: Retired
Component: Directory Server
Version: 1.2.6
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Nathan Kinder
QA Contact: Chandrasekar Kannan
URL:
Whiteboard:
Depends On:
Blocks: 639035
TreeView+ depends on / blocked
 
Reported: 2010-09-03 17:18 UTC by Nathan Kinder
Modified: 2015-01-04 23:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-17 14:08:52 UTC
Embargoed:

Attachments (Terms of Use)
Patch for cov#11778 (2.42 KB, patch)
2010-09-03 21:13 UTC, Nathan Kinder 		nhosoi: review+
nkinder: review?
Details | Diff
Patch for cov#15446 (1.18 KB, patch)
2010-09-03 21:13 UTC, Nathan Kinder 		nhosoi: review+
nkinder: review?
Details | Diff
Patch for cov#15447 (2.21 KB, patch)
2010-09-03 21:41 UTC, Nathan Kinder 		nhosoi: review+
Details | Diff
Patch for cov#15448 (1.91 KB, patch)
2010-09-03 22:12 UTC, Nathan Kinder 		nhosoi: review+
Details | Diff
Patch for cov#15449 (2.40 KB, patch)
2010-09-08 14:56 UTC, Nathan Kinder 		no flags Details | Diff
Patch for cov#15449 & cov#15450 (2.40 KB, patch)
2010-09-08 14:59 UTC, Nathan Kinder 		nhosoi: review+
nkinder: review?
Details | Diff
Patch for cov#15448 (1.91 KB, patch)
2010-09-08 17:34 UTC, Nathan Kinder 		nhosoi: review+
nkinder: review?
Details | Diff
Patch for cov#15447 (2.21 KB, patch)
2010-09-08 17:48 UTC, Nathan Kinder 		nhosoi: review+
nkinder: review?
Details | Diff
Show Obsolete (3) View All

Description Nathan Kinder 2010-09-03 17:18:49 UTC 
fix coverity Defect Type: Memory - Error handling issues
Comment 1 Nathan Kinder 2010-09-03 21:13:01 UTC 
Created attachment 442982 [details]
Patch for cov#11778
Comment 2 Nathan Kinder 2010-09-03 21:13:28 UTC 
Created attachment 442983 [details]
Patch for cov#15446
Comment 3 Nathan Kinder 2010-09-03 21:41:02 UTC 
Created attachment 442988 [details]
Patch for cov#15447
Comment 4 Nathan Kinder 2010-09-03 22:12:43 UTC 
Created attachment 442995 [details]
Patch for cov#15448
Comment 6 Nathan Kinder 2010-09-08 14:56:36 UTC 
Created attachment 446005 [details]
Patch for cov#15449
Comment 7 Nathan Kinder 2010-09-08 14:59:37 UTC 
Created attachment 446007 [details]
Patch for cov#15449 & cov#15450
Comment 8 Noriko Hosoi 2010-09-08 16:51:24 UTC 
Comment on attachment 442982 [details]
Patch for cov#11778

Found this "mroe" in the git commit comment. ;)
> bit mroe straightforward.
Comment 9 Nathan Kinder 2010-09-08 17:34:55 UTC 
Created attachment 446054 [details]
Patch for cov#15448

There was an error in the previous patch where some incorrect quoting was done.  This addresses that issue.
Comment 10 Nathan Kinder 2010-09-08 17:48:35 UTC 
Created attachment 446055 [details]
Patch for cov#15447

The old patch for this issue passed the incorrect number of parameters to LDAPDebug().  This addresses that issue.
Comment 11 Nathan Kinder 2010-09-08 17:52:29 UTC 
Pushed patches to master.  Thanks to Noriko for her reviews!

Counting objects: 49, done.
Delta compression using 2 threads.
Compressing objects: 100% (35/35), done.
Writing objects: 100% (35/35), 4.68 KiB, done.
Total 35 (delta 25), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   cd99e19..b2962bd  master -> master
Comment 12 Amita Sharma 2011-05-13 07:01:18 UTC 
Coverity Related, Can I request Dev to test this.
Note You need to log in before you can comment on or make changes to this bug.