Bug 630598 - bad handling of mdadm.conf in mkdumprd
Summary: bad handling of mdadm.conf in mkdumprd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kexec-tools
Version: 14
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neil Horman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-06 11:33 UTC by Jeff Layton
Modified: 2014-06-18 07:40 UTC (History)
4 users (show)

Fixed In Version: kexec-tools-2.0.0-39.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-16 03:50:56 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch to not find modules for mdadm (595 bytes, patch)
2010-09-15 18:29 UTC, Neil Horman
no flags Details | Diff

Description Jeff Layton 2010-09-06 11:33:59 UTC
mkdumprd does this:

if [ -f /etc/mdadm.conf ]
then
        cp /etc/mdadm.conf $MNTIMAGE/etc
        bin="$bin /sbin/mdadm"
        for i in `cat /etc/mdadm.conf | grep ARRAY | sed -e's/\(^.*level=\)\(.*$\)/\2/' | cut -d" " -f1`
        do
            findmodule $i
        done
fi


My mdadm.conf has this:

ARRAY /dev/md1 uuid=aebf2661:f2abc19d:9b68e17f:deb7fa33
ARRAY /dev/md5 uuid=65b98409:d47e87e6:45d32a1c:5f22a85e

When I run the stuff in backticks against it, I get this output:

$ cat /etc/mdadm.conf | grep ARRAY | sed -e's/\(^.*level=\)\(.*$\)/\2/' | cut -d" " -f1
ARRAY
ARRAY

...the findmodule command then fails to find any module called ARRAY (obviously).

Comment 1 Neil Horman 2010-09-15 18:29:25 UTC
Created attachment 447535 [details]
patch to not find modules for mdadm

I just realized that since we pull in all running modules now, we need to need to explicitly find the software raid modules.  Please confirm that this patch solves your issue.  Thanks!

Comment 2 Jeff Layton 2010-09-15 18:41:33 UTC
Thanks Neil. Yep, that seemed to fix it.

Comment 3 Fedora Update System 2010-09-15 20:36:06 UTC
kexec-tools-2.0.0-39.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kexec-tools-2.0.0-39.fc14

Comment 4 Fedora Update System 2010-09-16 03:50:51 UTC
kexec-tools-2.0.0-39.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.