Bug 632463 - Review Request: qtcontacts-tracker - QtContact tracker storage plugin
Summary: Review Request: qtcontacts-tracker - QtContact tracker storage plugin
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-10 02:36 UTC by Chen Lei
Modified: 2012-04-24 21:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-24 21:14:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Jason Tibbitts 2011-01-27 23:55:28 UTC
A few comments:

This builds fine, though much of the build does not go in parallel due to issues with the makefile:
make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.

There are a couple of rpmlint complaints that need fixing.  You should see them when you run rpmlint yourself so I shouldn't need to post them for you.  But....

qtcontacts-tracker.x86_64: W: incoherent-version-in-changelog 0.20.29-1 ['4.8.8-1.fc15', '4.8.8-1']
qtcontacts-tracker.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qt4/plugins/contacts/libqtcontacts_tracker.so ['/usr/lib64']

The first is simply the fact that the changelog entry seems to have nothing to do with the version of the package.  The latter you'll need to look into fixing.

The summary and description are a bit thin; even after reading them I've no idea what this package is supposed to do.

Why do you disable the tests?  When I see a comment to the effect that you're removing tests, I'm always going to ask why that's being done.

Comment 2 Jason Tibbitts 2012-04-24 21:14:45 UTC
No response in 15 months; closing.


Note You need to log in before you can comment on or make changes to this bug.