Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 636959

Summary: negotiator plug-in returns QMF error on valid sub-group attribute
Product: Red Hat Enterprise MRG Reporter: Pete MacKinnon <pmackinn>
Component: condor-qmfAssignee: Pete MacKinnon <pmackinn>
Status: CLOSED CURRENTRELEASE QA Contact: Lubos Trilety <ltrilety>
Severity: medium Docs Contact:
Priority: low    
Version: betaCC: ltrilety, matt, tross
Target Milestone: 1.3   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-10-21 18:44:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pete MacKinnon 2010-09-23 19:08:39 UTC
Code that checks for valid attribute names submitted through the negotiator QMF interface does not account for the dot ('.') separator used in group attributes like those that we would be used to set quota actions.

Comment 1 Pete MacKinnon 2010-09-23 19:15:32 UTC
FH sha 2b8c8b0

Comment 2 Lubos Trilety 2010-10-20 13:59:29 UTC
Please could you provide the reproduction scenario. Thanks

Comment 3 Matthew Farrellee 2010-10-20 15:23:36 UTC
http://git.fedorahosted.org/git/?p=grid.git;a=commit;h=2b8c8b0d951c4edbc0faef12b5c142bf1321a089

Above is the commit where this was fixed, it includes addition of a regression test in negotiator.py.

You may also need some config along the lines of,

 GROUP_QUOTA_DYNAMIC_MGMT.CUMIN = 1020

Comment 4 Lubos Trilety 2010-10-21 08:26:12 UTC
When I try that I found out that moreover it has to be enabled runtime configuration changes. After I edited those parameters it works fine: ENABLE_RUNTIME_CONFIG, ENABLE_PERSISTENT_CONFIG and PERSISTENT_CONFIG_DIR.

Reproduced on old version:
# python negotiator.py 
Current Negotiator:
ibm-mongoose.rhts.eng.bos.redhat.com
	OK (0) - {u'Limits': {}}
	OK (0) - {u'Value': 'group_physics, group_chemistry, group_physics.lab1, group_physics.lab2, group_physics.lab3, group_physics.lab3.team1, group_physics.lab3.team2, group_physics.lab3.team3, group_chemistry.lab1, group_chemistry.lab2'}
	1020
	Setting GROUP_QUOTA_DYNAMIC_MGMT.CUMIN to 1020.01
Call failed:  Invalid name for attribute - alphanumeric and underscore characters only (65538) - {}

Correct behaviour on new version:
# python negotiator.py
Current Negotiator:
dell-pe800-01.rhts.eng.bos.redhat.com
	OK (0) - {u'Limits': {}}
	OK (0) - {u'Value': 'group_physics, group_chemistry, group_physics.lab1, group_physics.lab2, group_physics.lab3, group_physics.lab3.team1, group_physics.lab3.team2, group_physics.lab3.team3, group_chemistry.lab1, group_chemistry.lab2'}
	1020
	Setting GROUP_QUOTA_DYNAMIC_MGMT.CUMIN to 1020.01

Tested with (version):
condor-qmf-7.4.4-0.16
condor-7.4.4-0.16

Tested on:
RHEL5 x86_64,i386  - passed
RHEL4 x86_64,i386  - passed

>>> VERIFIED