Bug 636959 - negotiator plug-in returns QMF error on valid sub-group attribute
Summary: negotiator plug-in returns QMF error on valid sub-group attribute
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: condor-qmf
Version: beta
Hardware: All
OS: Linux
low
medium
Target Milestone: 1.3
: ---
Assignee: Pete MacKinnon
QA Contact: Lubos Trilety
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-23 19:08 UTC by Pete MacKinnon
Modified: 2010-10-21 18:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-21 18:44:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Pete MacKinnon 2010-09-23 19:08:39 UTC
Code that checks for valid attribute names submitted through the negotiator QMF interface does not account for the dot ('.') separator used in group attributes like those that we would be used to set quota actions.

Comment 1 Pete MacKinnon 2010-09-23 19:15:32 UTC
FH sha 2b8c8b0

Comment 2 Lubos Trilety 2010-10-20 13:59:29 UTC
Please could you provide the reproduction scenario. Thanks

Comment 3 Matthew Farrellee 2010-10-20 15:23:36 UTC
http://git.fedorahosted.org/git/?p=grid.git;a=commit;h=2b8c8b0d951c4edbc0faef12b5c142bf1321a089

Above is the commit where this was fixed, it includes addition of a regression test in negotiator.py.

You may also need some config along the lines of,

 GROUP_QUOTA_DYNAMIC_MGMT.CUMIN = 1020

Comment 4 Lubos Trilety 2010-10-21 08:26:12 UTC
When I try that I found out that moreover it has to be enabled runtime configuration changes. After I edited those parameters it works fine: ENABLE_RUNTIME_CONFIG, ENABLE_PERSISTENT_CONFIG and PERSISTENT_CONFIG_DIR.

Reproduced on old version:
# python negotiator.py 
Current Negotiator:
ibm-mongoose.rhts.eng.bos.redhat.com
	OK (0) - {u'Limits': {}}
	OK (0) - {u'Value': 'group_physics, group_chemistry, group_physics.lab1, group_physics.lab2, group_physics.lab3, group_physics.lab3.team1, group_physics.lab3.team2, group_physics.lab3.team3, group_chemistry.lab1, group_chemistry.lab2'}
	1020
	Setting GROUP_QUOTA_DYNAMIC_MGMT.CUMIN to 1020.01
Call failed:  Invalid name for attribute - alphanumeric and underscore characters only (65538) - {}

Correct behaviour on new version:
# python negotiator.py
Current Negotiator:
dell-pe800-01.rhts.eng.bos.redhat.com
	OK (0) - {u'Limits': {}}
	OK (0) - {u'Value': 'group_physics, group_chemistry, group_physics.lab1, group_physics.lab2, group_physics.lab3, group_physics.lab3.team1, group_physics.lab3.team2, group_physics.lab3.team3, group_chemistry.lab1, group_chemistry.lab2'}
	1020
	Setting GROUP_QUOTA_DYNAMIC_MGMT.CUMIN to 1020.01

Tested with (version):
condor-qmf-7.4.4-0.16
condor-7.4.4-0.16

Tested on:
RHEL5 x86_64,i386  - passed
RHEL4 x86_64,i386  - passed

>>> VERIFIED


Note You need to log in before you can comment on or make changes to this bug.