Spec URL: http://www.annexia.org/tmp/virt-what.spec SRPM URL: http://www.annexia.org/tmp/virt-what-1.3-1.fc14.src.rpm Description: Virt-what detects various types of virtualization, including KVM, Xen, unaccelerated QEMU, VMWare, UML, VirtualBox, VirtualPC, OpenVZ. http://people.redhat.com/~rjones/virt-what/ Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2542489 rpmlint is silent.
Few suggestions: 1) as per latest packaging guidelines, if new package is supposed to be built on F13 and above then buildroot tag, %clean section and removal of buildroot in %install can be dropped. See https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and https://fedoraproject.org/wiki/PackagingGuidelines#.25clean 2) No need of prefix in make install 3) Good if you will add some comment above Requires: about why these explicit requires are needed for this package. 4) Looks BR: pod2man is not needed. See successful koji build without it http://koji.fedoraproject.org/koji/taskinfo?taskID=2542583 APPROVED.
(In reply to comment #1) Thanks for the quick review! > Few suggestions: > 1) as per latest packaging guidelines, if new package is supposed to be built > on F13 and above then buildroot tag, %clean section and removal of buildroot in > %install can be dropped. > > See https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and > https://fedoraproject.org/wiki/PackagingGuidelines#.25clean Right. I will drop these when I add it to Fedora, but keep them for RHEL 5. > 2) No need of prefix in make install Indeed, not sure how that crept in ... > 3) Good if you will add some comment above Requires: about why these explicit > requires are needed for this package. The shell script requires them, and I'm assuming that RPM cannot detect that. I will add a comment as suggested. > 4) Looks BR: pod2man is not needed. See successful koji build without it > http://koji.fedoraproject.org/koji/taskinfo?taskID=2542583 OK so pod2man is part of the default buildroot. I don't know if it's a good idea to depend on that? Seems like it could change in future and break the package, so an explicit BR is a good idea ...
New Package SCM Request ======================= Package Name: virt-what Short Description: detect if we are running in a virtual machine Owners: rjones mbooth Branches: f13 f14 InitialCC:
Zaagghhhh wrong person. Ignore comment 3, this is correct: New Package SCM Request ======================= Package Name: virt-what Short Description: detect if we are running in a virtual machine Owners: rjones mdbooth Branches: f13 f14 InitialCC:
While we're making changes, let's add virtmaint too: New Package SCM Request ======================= Package Name: virt-what Short Description: detect if we are running in a virtual machine Owners: rjones mdbooth virtmaint Branches: f13 f14 InitialCC:
(In reply to comment #2) > (In reply to comment #1) > > 4) Looks BR: pod2man is not needed. See successful koji build without it > > http://koji.fedoraproject.org/koji/taskinfo?taskID=2542583 > > OK so pod2man is part of the default buildroot. I don't know > if it's a good idea to depend on that? Seems like it could > change in future and break the package, so an explicit BR is > a good idea ... Even perl packageing don't recommend to add BR: perl as its redundant. And as you already know http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2, we don't need BR for this package. If you are going to add explicit BR then please add comment for that also.
(In reply to comment #5) > While we're making changes, let's add virtmaint too: > Owners: rjones mdbooth virtmaint Assuming virtmaint is just an email alias, it probably should be in > InitialCC: instead?
virtmaint can't be an owner. Did you mean it to be in cc?
New Package SCM Request ======================= Package Name: virt-what Short Description: detect if we are running in a virtual machine Owners: rjones mdbooth Branches: f13 f14 InitialCC:
Git done (by process-git-requests). You didn't answer Kevin's question - so I took the liberty of adding initcc virtmaint. If that is wrong drop me a quick mail and I can remove it.
Thanks everyone. Initial CC looks fine. Here are the builds: F15 http://koji.fedoraproject.org/koji/taskinfo?taskID=2561337 F14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2561344 F13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2561343
virt-what-1.3-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/virt-what-1.3-3.fc14
virt-what-1.3-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/virt-what-1.3-3.fc13
virt-what-1.3-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
virt-what-1.3-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.