Spec URL: http://pcarrier.fedorapeople.org/packages/xsettingsd/xsettingsd.spec SRPM URL: http://pcarrier.fedorapeople.org/packages/xsettingsd/xsettingsd-0.20091208-1.fc14.src.rpm Description: --- 8< --- xsettingsd is a daemon that implements the XSETTINGS specification. It is intended to be small, fast, and minimally dependent on other libraries. It can serve as an alternative to gnome-settings-daemon for users who are not using the GNOME desktop environment but who still run GTK+ applications and want to configure things such as themes, font antialiasing/hinting, and UI sound effects. --- >8 ---
fc14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2564473 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2564476
I am one of potential users of this app, so I will review it. I will sponsor you - what's your FAS name?
Unblocking FE-NEEDSPONSOR - I just sponsored pcarrier.
The package is simple and in a very good shape - I found only two issues: a) Versioning scheme is wrong. According to Fedora guidelines the proper scheme should be: Version: 0 Release: 0.1.20091208git%{commit_id}%{?dist} Note that I'm using %{commit_id}, so it should be defined somewhere above this line. Also you should fix %changelog entry version accordingly, e.g. * Fri Oct 29 2010 Pierre Carrier <prc> - 0-0.1.20091208git7804894 Note that you can't use macros with mutable values in %changelog (%{version}, %{release} or %{commit_id}) or all your change-log entries' records will be recalculated each build. b) You accidentally installed elf-binary instead of man-page at line 35. Proper install directive should be %{__install} -Dm0755 dump_xsettings.1 %{buildroot}%{_mandir}/man1/dump_xsettings.1 Please fix these issues and I'll continue.
Oh, I just found another one issue - the package doesn't honor Fedora CFLAGS. I don't know too much about scons, so I would just add the following line to the %prep section sed -i -e "s,-Wall -Werror,%{optflags},g" SConstruct
1) Fixed the ChangeLog, relocated the commit_id definition, changed Version: and Release: 2) Reused the sed expression with the | separator as "," appeared in %{optflags} Updated fedorapeople.org, no release bump as the original package was not distributed.
Thanks a lot for the sponsorship Peter. FAS username "pcarrier"
Ok, here is a koji scratchbuild for F-14 (wip currently): http://pcarrier.fedorapeople.org/packages/xsettingsd/xsettingsd.spec
Oops, wrong link: http://koji.fedoraproject.org/koji/taskinfo?taskID=2565734
Changed perms from 755 to 644 on the manpages, as discussed on XMPP. Packages updated.
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is NOT silent sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/xsettingsd-* xsettingsd.i686: W: spurious-executable-perm /usr/share/man/man1/xsettingsd.1.gz xsettingsd.i686: W: spurious-executable-perm /usr/share/man/man1/dump_xsettings.1.gz 2 packages and 0 specfiles checked; 0 errors, 2 warnings. sulaco ~/rpmbuild/SPECS: These messages were fixed already (just re-download spec-file). + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (BSD). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum derat-xsettingsd-7804894.tar.gz* fd7a6e6a8cc9c45ef230aba25b5167da2a4b61e229af34f68045eac0036cea84 derat-xsettingsd-7804894.tar.gz fd7a6e6a8cc9c45ef230aba25b5167da2a4b61e229af34f68045eac0036cea84 derat-xsettingsd-7804894.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. APPROVED.
New Package SCM Request ======================= Package Name: xsettingsd Short Description: Provides settings to X11 clients via the XSETTINGS specification Owners: pcarrier Branches: f14 el6 InitialCC: pcarrier
Git done (by process-git-requests).