SPEC: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-JSON/perl-CGI-Application-Plugin-JSON.spec SRPM: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-JSON/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.src.rpm Description: When communicating with client-side JavaScript, it is common to send data in X-JSON HTTP headers or through the document body as content-type application/json. This CGI::Application plugin adds a couple of convenience methods to make that just a little bit easier.
Source file original. Ok. License verified from README and lib/CGI/Application/Plugin/JSON.pm. Ok. > BuildRequires: perl(CGI::Application) FIX: Add `>= 4' version constrain to the BuildRequires (META.yml) > BuildRequires: perl(JSON) FIX: Add `>= 2.02' version constrain to the BuildRequires (META.yml) > BuildRequires: perl(JSON::Any) FIX: Add `>= 1.14' version constrain to the BuildRequires (META.yml) All tests pass. Ok. $ rpmlint perl-CGI-Application-Plugin-JSON.spec ../SRPMS/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.src.rpm ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm perl-CGI-Application-Plugin-JSON.noarch: E: zero-length /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/TODO 2 packages and 1 specfiles checked; 1 errors, 0 warnings. FIX: Do not pack empty TODO file. $ rpm -pq -lv ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02 -rw-r--r-- 1 root root 789 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/Changes -rw-r--r-- 1 root root 4459 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/README -rw-r--r-- 1 root root 0 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/TODO -rw-r--r-- 1 root root 3414 lis 4 18:03 /usr/share/man/man3/CGI::Application::Plugin::JSON.3pm.gz drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI/Application drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI/Application/Plugin -rw-r--r-- 1 root root 7192 lis 4 18:03 /usr/share/perl5/CGI/Application/Plugin/JSON.pm File layout and permissions are Ok. $ rpm -pq --requires ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(CGI::Application) 1 perl(JSON::Any) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 FIX: Add version to Requires: perl(CGI::Application) and perl(JSON::Any) as stated in META.yml. $ rpm -pq --provides ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm | sort | uniq -c 1 perl(CGI::Application::Plugin::JSON) = 1.02 1 perl-CGI-Application-Plugin-JSON = 1.02-1.fc13 Binary provides Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2577845). Ok. > + ./Build test > t/00-pod.t ........... ok > t/01-pod-coverage.t .. skipped: Test::Pod::Coverage 1.04 required for testing > POD coverage FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04 Otherwise package is in line with Fedora and Perl packaging guidelines. Ok. Please correct all `FIX' prefixed issues and submit new spec file. Resolution: Package NOT APPROVED.
Fix. SPEC: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-JSON/perl-CGI-Application-Plugin-JSON.spec SRPM: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-LinkIntegrity/perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc14.src.rpm
Spec file changes: --- perl-CGI-Application-Plugin-JSON.spec 2010-10-31 19:44:05.000000000 +0100 +++ perl-CGI-Application-Plugin-JSON.spec.1 2010-11-08 21:22:22.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-CGI-Application-Plugin-JSON Version: 1.02 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Easy manipulation of JSON headers License: GPL+ or Artistic Group: Development/Libraries @@ -8,12 +8,13 @@ Source0: http://www.cpan.org/authors/id/W/WO/WONKO/CGI-Application-Plugin-JSON-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch -BuildRequires: perl(CGI::Application) -BuildRequires: perl(JSON) -BuildRequires: perl(JSON::Any) +BuildRequires: perl(CGI::Application) >= 4 +BuildRequires: perl(JSON) >= 2.02 +BuildRequires: perl(JSON::Any) >= 1.14 BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) Requires: perl(CGI::Application) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -46,10 +47,13 @@ %files %defattr(-,root,root,-) -%doc Changes README TODO +%doc Changes README %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Mon Nov 08 2010 Emmanuel Seyman <emmanuel.seyman> - 1.02-2 +- Fix spec file per review + * Mon Oct 04 2010 Emmanuel Seyman <emmanuel.seyman> 1.02-1 - Specfile autogenerated by cpanspec 1.78. > > > BuildRequires: perl(CGI::Application) > > FIX: Add `>= 4' version constrain to the BuildRequires (META.yml) > +BuildRequires: perl(CGI::Application) >= 4 Ok. > > > BuildRequires: perl(JSON) > > FIX: Add `>= 2.02' version constrain to the BuildRequires (META.yml) > +BuildRequires: perl(JSON) >= 2.02 Ok. > > > BuildRequires: perl(JSON::Any) > > FIX: Add `>= 1.14' version constrain to the BuildRequires (META.yml) > +BuildRequires: perl(JSON::Any) >= 1.14 Ok. > > FIX: Do not pack empty TODO file. > -%doc Changes README TODO > +%doc Changes README $ rpm -pq -lv ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-2.fc13.noarch.rpm drwxr-xr-x 2 root root 0 lis 9 10:28 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02 -rw-r--r-- 1 root root 789 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/Changes -rw-r--r-- 1 root root 4459 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/README -rw-r--r-- 1 root root 3414 lis 9 10:28 /usr/share/man/man3/CGI::Application::Plugin::JSON.3pm.gz drwxr-xr-x 2 root root 0 lis 9 10:28 /usr/share/perl5/CGI drwxr-xr-x 2 root root 0 lis 9 10:28 /usr/share/perl5/CGI/Application drwxr-xr-x 2 root root 0 lis 9 10:28 /usr/share/perl5/CGI/Application/Plugin -rw-r--r-- 1 root root 7192 lis 9 10:28 /usr/share/perl5/CGI/Application/Plugin/JSON.pm Ok. > FIX: Add version to Requires: perl(CGI::Application) and perl(JSON::Any) as > stated in META.yml. All supported Fedoras fulfill minimal versions. Ok. > > FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04 > +BuildRequires: perl(Test::Pod::Coverage) All supported Fedoras fulfill minimal versions. Ok. All tests pass. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2589434). Ok. Resolution: Package APPROVED.
(In reply to comment #3) > > Resolution: Package APPROVED. Thanks, Petr. Requesting SCM New Package SCM Request ======================= Package Name: perl-CGI-Application-Plugin-JSON Short Description: Easy manipulation of JSON headers Owners: eseyman Branches: f14 f13 InitialCC: perl-sig
Git done (by process-git-requests).
perl-CGI-Application-Plugin-JSON-1.02-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-JSON-1.02-2.fc13
perl-CGI-Application-Plugin-JSON-1.02-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-JSON-1.02-2.fc14
perl-CGI-Application-Plugin-JSON-1.02-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-JSON'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-JSON-1.02-2.fc13
perl-CGI-Application-Plugin-JSON-1.02-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
perl-CGI-Application-Plugin-JSON-1.02-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.