SPEC: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-LinkIntegrity/perl-CGI-Application-Plugin-LinkIntegrity.spec SRPM: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-LinkIntegrity/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.src.rpm Description: CGI::Application::Plugin::LinkIntegrity lets you create tamper-resistant links within your CGI::Application project. When you create an URL with link, a check-sum is added to the URL. The check-sum is a (cryptographic) hash of the URL, plus a secret string known only to the server.
Source original. Ok. License verified from lib/CGI/Application/Plugin/LinkIntegrity.pm and README. Ok. FIX: Add perl(Digest::MD5) BuildRequires as the module can dual-live in the future (http://search.cpan.org/~gaas/Digest-MD5/). perl(CGI) and perl(CGI::Application) minimal versions are greater in all supported distributions. Missing versions are Ok. Summary and Description verified from lib/CGI/Application/Plugin/LinkIntegrity.pm. Ok. All tests pass. Ok. $ rpmlint perl-CGI-Application-Plugin-LinkIntegrity.spec ../SRPMS/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.src.rpm ../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -pq -vl ../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm drwxr-xr-x 2 root root 0 lis 5 17:43 /usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06 -rw-r--r-- 1 root root 2808 kvě 18 2006 /usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06/Changes -rw-r--r-- 1 root root 13592 kvě 18 2006 /usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06/README -rw-r--r-- 1 root root 6162 lis 5 17:43 /usr/share/man/man3/CGI::Application::Plugin::LinkIntegrity.3pm.gz drwxr-xr-x 2 root root 0 lis 5 17:43 /usr/share/perl5/CGI drwxr-xr-x 2 root root 0 lis 5 17:43 /usr/share/perl5/CGI/Application drwxr-xr-x 2 root root 0 lis 5 17:43 /usr/share/perl5/CGI/Application/Plugin -rw-r--r-- 1 root root 19092 lis 5 17:43 /usr/share/perl5/CGI/Application/Plugin/LinkIntegrity.pm File layout and permissions Ok. $ rpm -pq --requires ../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(CGI::Application) 1 perl(Digest::HMAC) 1 perl(Exporter) 1 perl(File::Spec) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(strict) 1 perl(URI) 1 perl(URI::QueryParam) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 Binary requires Ok. $ rpm -pq --provides ../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm | sort | uniq -c 1 perl(CGI::Application::Plugin::LinkIntegrity) = 0.06 1 perl-CGI-Application-Plugin-LinkIntegrity = 0.06-1.fc13 Binary provides Ok. Otherwise, package is in lines with Fedora and Perl packaging guidelines. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2579930). Ok. > t/pod-coverage.t .................. skipped: Test::Pod::Coverage 1.04 required for testing POD coverage FIX: Add perl(Test::Pod::Coverage ) >= 1.04 to BuildRequires. Please correct all `FIX' prefixed issues and submit new spec file. Resolution: Package NOT APPROVED.
Fix. SPEC: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-LinkIntegrity/perl-CGI-Application-Plugin-LinkIntegrity.spec SRPM: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-JSON/perl-CGI-Application-Plugin-JSON-1.02-2.fc14.src.rpm
Spec file changes: --- perl-CGI-Application-Plugin-LinkIntegrity.spec 2010-10-31 19:04:21.000000000 +0100 +++ perl-CGI-Application-Plugin-LinkIntegrity.spec.1 2010-11-08 21:21:51.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-CGI-Application-Plugin-LinkIntegrity Version: 0.06 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Make tamper-resistant links in CGI::Application License: GPL+ or Artistic Group: Development/Libraries @@ -11,9 +11,11 @@ BuildRequires: perl(CGI) BuildRequires: perl(CGI::Application) BuildRequires: perl(Digest::HMAC) +BuildRequires: perl(Digest::MD5) BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) >= 1.04 BuildRequires: perl(URI) BuildRequires: perl(URI::Escape) BuildRequires: perl(URI::QueryParam) @@ -53,5 +55,8 @@ %{_mandir}/man3/* %changelog +* Mon Nov 08 2010 Emmanuel Seyman <emmanuel.seyman> - 0.06-2 +- Fix spec file per review + * Sun Oct 31 2010 Emmanuel Seyman <emmanuel.seyman> 0.06-1 - Specfile autogenerated by cpanspec 1.78. > > FIX: Add perl(Digest::MD5) BuildRequires as the module can dual-live in the > > future (http://search.cpan.org/~gaas/Digest-MD5/). > +BuildRequires: perl(Digest::MD5) Ok. > > > t/pod-coverage.t .................. skipped: Test::Pod::Coverage 1.04 required for testing POD coverage > > FIX: Add perl(Test::Pod::Coverage ) >= 1.04 to BuildRequires. > +BuildRequires: perl(Test::Pod::Coverage) >= 1.04 Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2589305). Ok. Resolution: Package APPROVED.
(In reply to comment #3) > > Resolution: Package APPROVED. Thanks for the review. Requesting SCM New Package SCM Request ======================= Package Name: perl-CGI-Application-Plugin-LinkIntegrity Short Description: Make tamper-resistant links in CGI::Application Owners: eseyman Branches: f14 f13 InitialCC: perl-sig
Git done (by process-git-requests).
perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc13
perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc14
perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-LinkIntegrity'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc13
perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
perl-CGI-Application-Plugin-LinkIntegrity-0.06-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.