Bug 648304 - xscreensaver-demo popups warning about missing directory every time choosing hack
Summary: xscreensaver-demo popups warning about missing directory every time choosing ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xscreensaver
Version: 14
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-31 22:25 UTC by Pierre Carrier
Modified: 2010-11-21 01:29 UTC (History)
1 user (show)

Fixed In Version: xscreensaver-5.12-7.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-21 01:28:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Pierre Carrier 2010-10-31 22:25:38 UTC
Description of problem:
When running xscreensaver-demo after a fresh installation, xscreensaver-demo offers to start the daemon. After clicking OK, the following error is displayed and the daemon is not started:
Directory does not exist: "/usr/share/backgrounds/images"

Version-Release number of selected component (if applicable):
5.12-6.fc4

How reproducible:
100%

Steps to Reproduce:
1. Make sure neither gnome-backgrounds or desktop-backgrounds-basic are installed
2. "yum install xscreensaver"
3. Start xscreensaver-demo
4. Accept to start the daemon
  
Actual results:
1. This error is displayed:
"Directory does not exist: "/usr/share/backgrounds/images""
2. The daemon is not started

Expected results:
1. No error displayed
2. Daemon started

Additional info:
1. A dependency to /usr/share/backgrounds/images seems needed
2. /usr/share/backgrounds/images is provided by desktop-backgrounds-basic and gnome-backgrounds
3.a. desktop-backgrounds-basic only provides desktop-backgrounds and desktop-background-basics
3.b. gnome-backgrounds only provides gnome-backgrounds
4. Installing either packages fixes the issue

Comment 1 Mamoru TASAKA 2010-11-01 07:26:16 UTC
Well, actually /usr/share/backgrounds/images is not strictly needed.
xscreensaver daemon launches even if the directory does not exist,
and hacks in xscreensaver which uses images also work.

The issue here may be:
- The popup message says it is "Error", although perhaps it should be
  "Warning"
- The popup message shows up every time you choose demo hack, which is
  very annoying.

I will discuss with jwz with sending him a proposal patch for this.

Comment 2 Pierre Carrier 2010-11-01 09:08:52 UTC
Thanks Mamoru!

Taking your feedback into consideration, I'd personally prefer this popup to be completely disabled. Other opinions welcome :)

-- 
Pierre Carrier

Comment 3 Mamoru TASAKA 2010-11-08 14:22:38 UTC
Still no reply from jwz, however FYI:

Currently I am thinking of poping up "warning" (not "error") message
of missing image directory when

- Never warned before (i.e. only once)
- Image directory was changed in xscreensaver-demo and the new
  image directory does not exist (then warn once)

If you agree with this, I will update Fedora xscreensaver
(I already sent a patch for this about one week ago. If upstream
 disagrees with my patch, I will discuss it again)

Comment 4 Fedora Update System 2010-11-10 17:23:22 UTC
xscreensaver-5.12-7.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xscreensaver-5.12-7.fc14

Comment 5 Fedora Update System 2010-11-10 17:23:59 UTC
xscreensaver-5.12-7.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/xscreensaver-5.12-7.fc13

Comment 6 Fedora Update System 2010-11-10 17:24:54 UTC
xscreensaver-5.12-7.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/xscreensaver-5.12-7.fc12

Comment 7 Fedora Update System 2010-11-11 22:18:18 UTC
xscreensaver-5.12-7.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xscreensaver'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/xscreensaver-5.12-7.fc12

Comment 8 Fedora Update System 2010-11-21 01:28:08 UTC
xscreensaver-5.12-7.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-11-21 01:28:42 UTC
xscreensaver-5.12-7.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2010-11-21 01:28:58 UTC
xscreensaver-5.12-7.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.