Bug 651815 - meld should require 'patch'
Summary: meld should require 'patch'
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: meld
Version: 14
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 606987 627251 657515 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-10 11:28 UTC by pankaj pandey
Modified: 2011-04-19 18:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-19 18:11:47 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description pankaj pandey 2010-11-10 11:28:42 UTC
Description of problem:
Some functionality (visual two-pane diff of files in version control (hg)) of meld is unavailable if patch is not installed

Version-Release number of selected component (if applicable):
meld-1.3.2-1.fc14.noarch


Steps to Reproduce:
1. install meld, remove patch
2. create a mercurial working copy (repo), edit some files
3. cd to the directory and run the command 'meld .'
4. local modified files are displayed in meld window
5. double click on any locally modified text file (colored red)


Actual results:
See the terminal window, following error message is shown:

Traceback (most recent call last):
  File "/usr/share/meld/meld/task.py", line 130, in iteration
    ret = task()
  File "/usr/share/meld/meld/vcview.py", line 362, in run_diff_iter
    self.show_patch(prefix, patch)
  File "/usr/share/meld/meld/vcview.py", line 500, in show_patch
    if misc.write_pipe(patchcmd, patch) == 0:
  File "/usr/share/meld/meld/misc.py", line 242, in write_pipe
    proc = subprocess.Popen(command, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
  File "/usr/lib64/python2.7/subprocess.py", line 672, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1201, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory


Expected results:
A visual two-pane diff of the file is shown in a new tab.
It can be easily checked by installing 'patch'

Additional info:
The 'command' variable in /usr/share/meld/meld/misc.py:242 in above stacktrace is:
['patch', '--strip=1', '--reverse', '--directory=/tmp/tmptnY5qf-meld']
which led me to discover that 'patch' is required but not installed.

Comment 1 Sandro Bonazzola 2010-12-01 09:39:52 UTC
This could be keyworded EasyFix, just adding patch to Requires.

Comment 2 Sandro Bonazzola 2011-01-19 07:05:42 UTC
Is anybody still maintaining meld?

Comment 3 Sandro Bonazzola 2011-02-02 07:12:11 UTC
http://fedoraproject.org/wiki/PackageMaintainers/Policy/NonResponsiveMaintainers

Is anybody still maintaining meld?

Comment 4 pankaj pandey 2011-02-02 07:54:57 UTC
This is a very minor issue and the meld package is really very useful to me please don't orphan this package even if the maintainer is currently non-responsive.
Thanks

Comment 5 Fedora Admin XMLRPC Client 2011-03-13 15:38:45 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 6 Michael Schwendt 2011-03-13 16:24:50 UTC
*** Bug 657515 has been marked as a duplicate of this bug. ***

Comment 7 Dominic Hopf 2011-03-13 17:43:42 UTC
*** Bug 627251 has been marked as a duplicate of this bug. ***

Comment 8 Dominic Hopf 2011-03-13 17:45:58 UTC
*** Bug 606987 has been marked as a duplicate of this bug. ***

Comment 9 Dominic Hopf 2011-04-17 18:13:04 UTC
Meld is still maintained, yes. Is it possible for you to check if the issue is still reproducible with the new meld 1.5.1? The package can be obtained here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3007032

Comment 10 pankaj pandey 2011-04-18 05:54:19 UTC
Thanks for the fix and the new build. This one does install patch as a dependency, so the issue is fixed and this bug can be closed i suppose.

Comment 11 Dominic Hopf 2011-04-19 18:11:47 UTC
Thanks very much for the feedback and the testing. :)


Note You need to log in before you can comment on or make changes to this bug.