Spec URL: http://sergiopr.fedorapeople.org/pywcs.spec SRPM URL: http://sergiopr.fedorapeople.org/pywcs-1.9-1.fc14.src.rpm Description: pywcs is a set of routines for handling the FITS World Coordinate System (WCS) standard. It is a thin wrapper around the high- and mid-level interfaces of Dr. Mark Calabretta's WCSLIB.
Just some quick comments: - There is an example directory. Include this can help the users. - The same with the stuff in /doc - CHANGELOG is missing
I have added CHANGELOG and examples. To build doc, a missing module (stsci_sphinxext.conf) is required Spec URL: http://sergiopr.fedorapeople.org/pywcs.spec SRPM URL: http://sergiopr.fedorapeople.org/pywcs-1.9-2.fc14.src.rpm
Quick informal review: the first macro python_sitearch can be removed if you not plan to included the package in EPEL4/5 (no blocker) see: http://fedoraproject.org/wiki/Packaging/Python#Macros You may also want to add a comment to the Requries tag as rpmbuild my not be able to resolve the deps by it self. (non blocker though)
New upstream version Spec URL: http://sergiopr.fedorapeople.org/pywcs.spec SRPM URL: http://sergiopr.fedorapeople.org/pywcs-1.10-1.fc16.src.rpm
I'll review this one
All looks fine. APPROVED If your not planning on packaging for EPEL-5 or earlier you can remove the %clean section. + rpmlint output rpmlint pywcs.spec pywcs-debuginfo-1.9-1.fc16.x86_64.rpm pywcs-1.9-1.fc16.x86_64.rpm pywcs-1.9-1.fc16.src.rpm pywcs.x86_64: W: incoherent-version-in-changelog 1.9-2 ['1.9-1.fc16', '1.9-1'] pywcs.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/pywcs/_pywcs.so _pywcs.so()(64bit) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 8f7b2b48a0ee6e775ff2c9c17a4e3985 pywcs-1.10-4.7.tar.gz + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files
New Package SCM Request ======================= Package Name: pywcs Short Description: Python World Coordinate System routines Owners: sergiopr Branches: F-15 F-14 F-13 EL-6 InitialCC:
Git done (by process-git-requests).