Bug 654879 - Review Request: since - stateful tail
Summary: Review Request: since - stateful tail
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Martin Gieseking
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-18 22:33 UTC by Sven Lankes
Modified: 2012-06-05 19:39 UTC (History)
6 users (show)

Fixed In Version: since-1.1-3.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-05 02:33:17 UTC
Type: ---
Embargoed:
martin.gieseking: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Sven Lankes 2010-11-18 22:33:57 UTC
Spec URL: http://sven.lank.es/Fedora/SPECS/since.spec
SRPM URL: http://sven.lank.es/Fedora/SRPMS/since-1.1-1.fc14.src.rpm

Description:  Since is a unix utility similar to tail. Unlike tail, since only shows the lines appended since the last time. It is useful to monitor
growing log files

Comment 1 François Cami 2010-11-18 23:02:11 UTC
I'll do a full review shortly. In the meantime, could you fix the following errors:

since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately
since.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni
since.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

At least the second and third error, the first is OK.

Comment 2 Jason Tibbitts 2010-11-18 23:22:36 UTC
no-buildroot-tag is not an error.  Fedora hasn't required BuildRoot: since F10.  It doesn't require %clean or the buildroot cleaning in %install, either.

Comment 3 Sven Lankes 2010-11-18 23:27:14 UTC
Thanks for looking at since.

New version:

Spec URL: http://sven.lank.es/Fedora/SPECS/since.spec
SRPM URL: http://sven.lank.es/Fedora/SRPMS/since-1.1-2.fc14.src.rpm

I've changed unix to Unix. And removed %clean and the buildroot cleaning in 
%install as Jason noted.

Comment 4 Pavel Alexeev 2010-11-20 15:08:35 UTC
(In reply to comment #2)
> no-buildroot-tag is not an error.  Fedora hasn't required BuildRoot: since F10.
>  It doesn't require %clean or the buildroot cleaning in %install, either.
Until it is not intended for EPEL5 too.

Comment 5 Sven Lankes 2011-01-17 19:52:23 UTC
Ping.

François - are you going to do the review? If not please

Comment 6 François Cami 2011-01-17 20:42:42 UTC
Releasing. Sorry, I haven't got enough time to do it properly.

Comment 7 Martin Gieseking 2011-01-21 12:31:35 UTC
Hi Sven,

are you still interested in submitting this package? The URLs given in comment #3 seem to be dead (404).

Comment 8 Sven Lankes 2011-01-21 15:29:24 UTC
(In reply to comment #7)

> are you still interested in submitting this package? The URLs given in comment
> #3 seem to be dead (404).

Sorry - I didn't notice that.

I am still interested. New urls:

Spec URL: http://yuio.de/Fedora/SPECS/since.spec
SRPM URL: http://yuio.de/Fedora/SRPMS/since-1.1-2.fc14.src.rpm

Comment 9 Martin Gieseking 2011-01-21 16:28:01 UTC
Here are some comments on your latest spec:

- I recommend not to adapt the Makefile but assign the proper CFLAGS in the make
  statement instead:
  make CFLAGS='%{optflags} -DVERSION=\"%{version}\"' %{?_smp_mflags}
  This is much safer since sed might silently fail if the pattern doesn't 
  match.

- use macro %{_prefix} in the %install section:
  make install prefix=$RPM_BUILD_ROOT/%{_prefix} INSTALL='install -Dp'

- clear the exec perms of the manpage (in %install), e.g.:
  chmod 644 $RPM_BUILD_ROOT/%{_mandir}/man1/since.1

- in %files, please use either the %{name} macro or "since". Don't mix them:

  %{_bindir}/%{name}
  %{_mandir}/man1/%{name}.1*

  or

  %{_bindir}/since
  %{_mandir}/man1/since.1*

- replace %clean with %%clean in the %changelog to make rpmlint happy


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately
since.src:35: W: macro-in-%changelog %clean
since.x86_64: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately
since.x86_64: W: spurious-executable-perm /usr/share/man/man1/since.1.gz
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 10 Sven Lankes 2011-01-31 18:10:58 UTC
Thanks for looking at the spec - I've fixed the issues you pointed out:

Spec URL: http://yuio.de/Fedora/SPECS/since.spec
SRPM URL: http://yuio.de/Fedora/SRPMS/since-1.1-3.fc14.src.rpm

Comment 11 Martin Gieseking 2011-01-31 18:54:41 UTC
The package looks good now. Just add a final dot to the %description text. :)
As you probably don't want to build the package for EPEL < 6, you can ignore the [X]-marked items below.


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
since.src: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately
since.x86_64: W: spelling-error Summary(en_US) Stateful -> Tasteful, Stateless, Stately
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

The spelling errors are false positive.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPLv3+ according to README

[+] MUST: The License field in the package spec file must match the actual license.
[+] MUST: The file containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum since-1.1.tar.gz*
    7a6cfe573d0d2ec7b6f53fe9432a486b  since-1.1.tar.gz
    7a6cfe573d0d2ec7b6f53fe9432a486b  since-1.1.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
    koji scratch build (f15):
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2753430

[+] MUST: If the package does not successfully compile, build or work on an architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file.
[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

[.] SHOULD: If the source package does not include license text(s) as a separate file ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[+] SHOULD: Your package should contain man pages for binaries/scripts.

----------------
Package APPROVED
----------------

Comment 12 Martin Gieseking 2011-02-22 08:40:51 UTC
Sven, what's the status of this bug? Don't you want to request a Git repo for the package?

Comment 13 Sven Lankes 2011-02-24 22:16:26 UTC
New Package SCM Request
=======================
Package Name: since
Short Description: Stateful tail replacement
Owners: slankes
Branches: f15 el6

Comment 14 Jason Tibbitts 2011-02-25 03:11:44 UTC
Git done (by process-git-requests).

Comment 15 Fedora Update System 2011-02-27 18:09:30 UTC
Package since-1.1-3.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing since-1.1-3.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/since-1.1-3.fc15
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2011-03-01 06:45:37 UTC
since-1.1-3.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update since'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/since-1.1-3.fc15

Comment 17 Fedora Update System 2011-03-05 02:33:08 UTC
since-1.1-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Till Maas 2012-06-05 19:34:08 UTC
I discussed with the owner of the package using private mail, that I maintain the EL5 branch of this package.

Package Change Request
======================
Package Name: since
New Branches: el5
Owners: till

Comment 19 Gwyn Ciesla 2012-06-05 19:39:10 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.