Spec URL: http://asrob.fedorapeople.org/drupal6-mimedetect.spec SRPM URL: http://asrob.fedorapeople.org/drupal6-mimedetect-1.3-1.fc14.src.rpm Description: MimeDetect provides an API for consistent server side mime detection using the PHP FileInfo extension, the UNIX 'file' command, user supplied mime data, or file extension lookups. It is distributed with its own magic library for use with the PHP FileInfo extension to make mime detection more consistent in different environments. rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-mimedetect.spec ../SRPMS/drupal6-mimedetect-1.3-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2618146 Watching tasks (this may be safely interrupted)... 2618146 build (dist-f14, drupal6-mimedetect-1.3-1.fc14.src.rpm): open (ppc06.phx2.fedoraproject.org) 2618147 buildArch (drupal6-mimedetect-1.3-1.fc14.src.rpm, i386): open (x86-02.phx2.fedoraproject.org) 2618147 buildArch (drupal6-mimedetect-1.3-1.fc14.src.rpm, i386): open (x86-02.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2618146 build (dist-f14, drupal6-mimedetect-1.3-1.fc14.src.rpm): open (ppc06.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2618146 build (dist-f14, drupal6-mimedetect-1.3-1.fc14.src.rpm) completed successfully
Please correct the license to GPLv2+, as all modules hosted in Drupal's CVS must be.
http://asrob.fedorapeople.org/SOURCES/drupal6-mimedetect.spec http://asrob.fedorapeople.org/SOURCES/drupal6-mimedetect-1.3-2.fc14.src.rpm Fixed.
http://asrob.fedorapeople.org/SOURCES/drupal6-mimedetect.spec http://asrob.fedorapeople.org/SOURCES/drupal6-mimedetect-1.3-3.fc14.src.rpm Updated files.
[+] Good [x] Needs work [0] Does not apply MUST: ===== [+] Naming according to the Package Naming Guidelines [+] Spec file matches base package name [+] Packaging guidelines met [+] License approved for Fedora [+] License field in spec matches [+] License file included, if source package includes it [+] Spec in American English [+] Spec is legible [+] rpmlint: [makerpm@fedora13 SPECS]$ rpmlint ../SRPMS/drupal6-mimedetect-1.3-3.fc13.src.rpm ../RPMS/noarch/drupal6-mimedetect-1.3-3.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [+] Sources match upstream md5sum: cb675a6eb6a75a332b8aa23e0b6501cb [+] Builds into binary RPMs on at least one primary architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=2757803 [0] ExcludeArch is specified and commented: [0] All build dependencies listed [0] The spec file handles locales properly [0] Calls ldconfig for its shared libraries [0] No bundled system libraries [0] Stated as relocatable package [+] Owns all its directories or requires packages that do [+] No file listing duplicates [+] File permissions correct [+] Consistent use of macros [+] Code or permissible content [0] Large documentation in -doc subpackage [+] No runtime dependency of files listed as %doc [0] Header files in -devel subpackage [0] Static files in -static subpackage [0] Library files without suffix in -devel subpackage [0] Devel-package requires base package [0] No .la libtool archives [0] GUI application includes properly installed %{name}.desktop file [+] No files or directories owned, that other packages own [+] Filenames in packages are UTF-8 SHOULD: ======= [0] Query upstream if no license text is included [+] Package builds in mock: (epel-6-x86_64) [0] Scriptlets are sane, if used [0] Subpackages other than -devel should require base package (versioned) [0] pkgconfig files in -devel subpackage [0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself [0] Contain man pages, where they make sense I didn't try whether it works. NOTE: ===== Please remove the name from the summary. Files can be simplified to: ... %doc LICENSE.txt %{name}-fedora-README.txt README.txt %{drupaldir}/modules/mimedetect %exclude %{drupaldir}/modules/mimedetect/*.txt %dir is only necessary in the other packages, because there are translations. This package doesn't have any. Nevertheless, it is not wrong. The chmod is not necessary, as I said before. If the permissions are right, they are right. -------- APPROVED --------
Are you still interested in this package? You haven't requested SCM so far.
It seems, yes, I am, just we're working on our basic features and this is not part of that. I think we'll use this one when we'll be working on the podcast ideas. Thank you for the reminder.