Bug 662949 - Review Request: freedups - Hard-links identical files to save space
Review Request: freedups - Hard-links identical files to save space
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2010-12-14 04:10 EST by Thierry Vignaud
Modified: 2012-04-24 18:41 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-04-24 18:41:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Thierry Vignaud 2010-12-14 04:10:23 EST
Spec URL: http://kenobi.mandriva.com/~tv/FC/freedups.spec
SRPM URL: http://kenobi.mandriva.com/~tv/FC/freedups-0.6.14-1.fc14.src.rpm
Description: 
Freedups hard-links identical files to save space.  For files that are
generally read from and not written to, this can provide a
significant space savings with no performance degradation.  In fact,
in a small number of cases, this can speed up the system.

This is my first package for Fedora (I'm packaging for Mandriva Linux
since 1999), and I'm seeking a sponsor for Fedora.
Comment 1 Michael Schwendt 2010-12-25 04:21:53 EST
Brief look at the spec file only (no full review):

It is likely that some of these issues are reported by rpmlint, too, so please run rpmlint on the src.rpm package and the built rpms.


> %define name	freedups
> %define	version	0.6.14
> %define release 1%{?dist}
>
> Name:		%{name}	
> Version:	%{version}
> Release:	%{release}	

Why the extra redefinition? "Name:" defines %name, "Version:" defines %version, and "Release:" defines %release already. It's sufficient to just write:

Name:		freedups
Version:	0.6.14
Release:	1%{?dist}


> License:	GPL

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL

plus

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification

since the license text is not included, and all that's there is the brief comment (from 2002?) that "GPL" is used. It cannot be assumed that it is GPLv2+.


> BuildRoot:	%{_tmppath}/%{name}--buildroot

Note that several details related to the BuildRoot are not needed anymore since Fedora 13:

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


> install -m755 %{name}.pl $RPM_BUILD_ROOT%{_bindir}/%{name}

Typically, option -p is used for "install" or "cp" to preserve timestamps. Less useful for files which change often, but added value for old files, so one can quickly notice the age of a file (e.g. ancient Documentation).
Comment 2 Thomas Spura 2011-11-26 09:15:21 EST
Any news here?

The spec from above is not accessible anymore...
Comment 3 Jason Tibbitts 2012-04-24 18:41:43 EDT
No response and no package to review  in many months now; closing.

Note You need to log in before you can comment on or make changes to this bug.