Spec URL: http://kenobi.mandriva.com/~tv/FC/freedups.spec SRPM URL: http://kenobi.mandriva.com/~tv/FC/freedups-0.6.14-1.fc14.src.rpm Description: Freedups hard-links identical files to save space. For files that are generally read from and not written to, this can provide a significant space savings with no performance degradation. In fact, in a small number of cases, this can speed up the system. This is my first package for Fedora (I'm packaging for Mandriva Linux since 1999), and I'm seeking a sponsor for Fedora.
Brief look at the spec file only (no full review): It is likely that some of these issues are reported by rpmlint, too, so please run rpmlint on the src.rpm package and the built rpms. > %define name freedups > %define version 0.6.14 > %define release 1%{?dist} > > Name: %{name} > Version: %{version} > Release: %{release} Why the extra redefinition? "Name:" defines %name, "Version:" defines %version, and "Release:" defines %release already. It's sufficient to just write: Name: freedups Version: 0.6.14 Release: 1%{?dist} > License: GPL https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL plus https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification since the license text is not included, and all that's there is the brief comment (from 2002?) that "GPL" is used. It cannot be assumed that it is GPLv2+. > BuildRoot: %{_tmppath}/%{name}--buildroot Note that several details related to the BuildRoot are not needed anymore since Fedora 13: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > install -m755 %{name}.pl $RPM_BUILD_ROOT%{_bindir}/%{name} Typically, option -p is used for "install" or "cp" to preserve timestamps. Less useful for files which change often, but added value for old files, so one can quickly notice the age of a file (e.g. ancient Documentation).
Any news here? The spec from above is not accessible anymore...
No response and no package to review in many months now; closing.