Spec URL: http://twoerner.fedorapeople.org/firewalld/firewalld.spec SRPM URL: http://twoerner.fedorapeople.org/firewalld/firewalld-0.1-1.fc14.src.rpm Description: firewalld is a firewall service daemon that provides a dynamic customizable firewall with a D-BUS interface. For more information, please have a look at: http://twoerner.fedorapeople.org/firewalld and git://git.fedorahosted.org/git/firewalld.git
FAIL: >rpmlint /tmp/firewalld-0.1-1.fc14.src.rpm firewalld.src: W: spelling-error %description -l en_US customizable -> customization, customize, customarily firewalld.src:84: W: mixed-use-of-spaces-and-tabs (spaces: line 84, tab: line 64) firewalld.src: W: invalid-url Source0: https://fedorahosted.org/released/firewalld/firewalld-0.1.tar.bz2 HTTP Error 404: Not Found >rpmlint /tmp/firewall-applet-0.1-1.fc14.noarch.rpm firewall-applet.noarch: W: spelling-error %description -l en_US firewalld -> firewalls, firewall, firewall d firewall-applet.noarch: W: no-documentation >rpmlint /tmp/firewalld-0.1-1.fc14.noarch.rpm firewalld.noarch: W: spelling-error %description -l en_US customizable -> customization, customize, customarily firewalld.noarch: E: non-executable-script /usr/share/firewalld/server.py 0644L /usr/bin/python firewalld.noarch: E: non-executable-script /usr/share/firewalld/ipXtables.py 0644L /usr/bin/python firewalld.noarch: E: non-executable-script /usr/share/firewalld/firewall.py 0644L /usr/bin/python firewalld.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/FirewallD.conf firewalld.noarch: E: non-executable-script /usr/share/firewalld/modules.py 0644L /usr/bin/python firewalld.noarch: E: non-executable-script /usr/share/firewalld/ebtables.py 0644L /usr/bin/python firewalld.noarch: E: non-executable-script /usr/share/firewalld/firewall_functions.py 0644L /usr/bin/python firewalld.noarch: W: incoherent-subsys /etc/rc.d/init.d/firewalld $prog the 'customizable' spelling error can be ignored, it looks like that's a missing word in the DB. OK - package meets naming guidelines OK - package meets packaging guidelines: No inclusion of pre-built binaries or libraries Architecture Support Filesystem Layout, except non-conf files in /etc, see rpmlint Changelogs FAIL: Source tag, tarball not available at the given URL OBSOLETE: BuildRoot tag, F10+ does not require the presence of the BuildRoot tag in the spec and if one is defined it will be ignored. OBSOLETE: %clean not required for F-13+ FAIL: Requires(post): /sbin/chkconfig is missing FAIL: license GPLv2+ OK, text in %doc, matches source, but old version of GPL2 with old FSF address included - spec file legible, in am. english FAIL: source matches upstream, not provable as upstream sources are missing - package compiles on devel (x86), http://koji.fedoraproject.org/koji/taskinfo?taskID=2698131 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime
Hi Karsten, thanks for the review. Here is the fixed package.. FIXED: Source tag, tarball not available at the given URL FIXED: Requires(post) and (pre) for chkconfig FIXED: license FIXED: source uploaded to https://fedorahosted.org/released/ FIXED: non-executable-scripts FIXED: non-conffile-in-etc /etc/dbus-1/system.d/FirewallD.conf FIXED: mixed-use-of-spaces-and-tabs NOTABUG: incoherent-subsys If I am replacing $prog in lockfile=/var/lock/subsys/$prog with firewalld, then the error is gone. $prog contains firewalld, therefore this is not a bug. NOTABUG: The spelling warning seems to be a dictionary problem. NOTABUG: firewall-applet does not have a separate documentation and it is requiring the base package that contains %doc Please have a look at: http://twoerner.fedorapeople.org/firewalld/firewalld.spec http://twoerner.fedorapeople.org/firewalld/firewalld-0.1.2-1.fc14.src.rpm Thanks, Thomas
Looks good to me now, setting fedora-review+
New Package SCM Request ======================= Package Name: firewalld Short Description: A firewall daemon with D-BUS interface providing a dynamic firewall Owners: twoerner Branches: f15 InitialCC:
This ticket is not assigned to anyone. It should be assigned to the reviewer. Also, it is too early to request f15 branches. Please fix these issues and re-raise the fedora-cvs flag.
New Package SCM Request ======================= Package Name: firewalld Short Description: A firewall daemon with D-BUS interface providing a dynamic firewall Owners: twoerner Branches: InitialCC:
Git done (by process-git-requests).
Here is the build: http://koji.fedoraproject.org/koji/buildinfo?buildID=213149