Spec URL: http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater.spec SRPM URL: http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater-1.2-1.fc14.src.rpm Description: A module that provides lazy strings for translations. Basically you get an object that appears to be a string but changes the value every time the value is evaluated based on a callable you provide. I want to note that this is my first package and I need sponsor please. RPMLINT SUMMARY: - SRPM * 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - SPEC * 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
I have tested it and it's OK. The SPEC Filename, Package Name, Version and Release are appropiate. The Requires are fine. I installed it without any problems.
New Package SCM Request ======================= Package Name: python-speaklater Short Description: implements a lazy string for python useful for use with gettext Owners: haks Branches: f13 f14 f15 el5 el6 InitialCC: potty gomix
Something is a bit odd with this ticket. First, you should raise the fedora-cvs flag when submitting SCM requests so that they will be seen. Second, I cannot find any FAS account named "haks". I found "xhaksx", but that account is not part of the packager group and cannot own packages. Third, I cannot find any FAS account containing the string "Lassonde". Abdel, what is your FAS ID? I thought I knew most of the sponsors, but that name is not familiar to me. Are you really a sponsor? You cannot review Juan's package if you are not.
NEEDSWORK Good: * rpmlint: python-speaklater.noarch: W: spelling-error Summary(en_US) gettext -> get text, get-text, getter python-speaklater.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, getter 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Those are ignorable * named according to the guidelines * spec file matches package name * license is BSD in spec and package itself which is an approved free software license * spec file is readable * Source matches upstream and upstream URL is canonical * No locales so no need for %find_lang * Not a C library * No bundled system libraries * Not relocatable * Package owns all files and directories it creates and nothing else * Permissions set properly * Macros used consistently * Code, not content * No large documentation files * Not a GUI application * All filenames valid UTF-8 MUST FIX: * Package does not build in koji : Package builds in koji - The reason is related to the %install section that I'll explain below. Should do: * I see that upstream has a LICENSE and a README file in their git repository. You should send them an email to have them include those in their releases. They probably need a MANIFEST.in file that lists those (something like: MANIFEST.in: include README LICENSE Notes: There's a couple non-Fedora-standard things in here. One of those is contributing to the build failure. This page https://fedoraproject.org/wiki/Packaging:Python has the python-specific guidelines for Fedora. If you take a look you'll see that your %install section and %files section are a bit different. In this section, it recommends not to use --record=INSTALLED_FILES https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling. In this section, there's a simple example of what the install section should look like: https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools (sorry it's hidden away and the more complex python2/python3 spec is on the main page.) Basically instead of this: %{__python} setup.py install --single-version-externally-managed -O1 --root=%{buildroot} --record=INSTALLED_FILES [..] %files -f INSTALLED_FILES You should have this: %{__python} setup.py install --root=%{buildroot} [..]] %files %{python_sitelib}/* The reason that this is contributing to a build failure is that the setup.py file is conditionally using setuptools to build. When it uses setuptools, --single-version-externally-managed is a valid command line option. When it only uses distutils, that option is not available. You could BuildRequire: setuptools to fix that but it's simpler to just make the setup.py install line reflect what the guidelines suggest which works with both distutils and setuptools. If you fix those things, I can try building in koji again and approve this package. As discussed on IRC, you're also looking at reviewing a package and then I'll sponsor you.
I applied the corrections Spec URL: http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater.spec SRPM URL: http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater-1.2-4.fc14.src.rpm RPMLINT SUMMARY: - SRPM * 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - SPEC * 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
All problems taken care of. The package is APPROVED. Now to get you sponsored....
WARNING: "haks" is not a valid FAS account. Can you work with your sponsor to get your account setup, then reset the fedora-cvs flag? thanks.
New Package SCM Request ======================= Package Name: python-speaklater Short Description: implements a lazy string for python useful for use with gettext Owners: xhaksx Branches: f13 f14 f15 el5 el6 InitialCC: potty gomix toshio
f15 is not a valid branch - please resubmit with correct branches.
Well, it's a valid branch as of now, so.... Git done (by process-git-requests).
This message is a notice that Fedora 14 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 14. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '14' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 14 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping