Bug 666969 - Run pypy in %check both within valgrind and directly; seeing serious-looking valgrind warnings
Summary: Run pypy in %check both within valgrind and directly; seeing serious-looking ...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: pypy
Version: 19
Hardware: Unspecified
OS: Linux
low
medium
Target Milestone: ---
Assignee: Matej Stuchlik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-03 20:56 UTC by Dave Malcolm
Modified: 2016-02-01 02:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-17 13:33:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dave Malcolm 2011-01-03 20:56:13 UTC
Description of problem:
When running pypy in pypy.spec's %check, we should run things twice: directly, and under valgrind (iirc, pypy can detect if it's run under valgrind, so we should run both cases).

Unfortunately, I'm seeing worrying memory errors when running pypy under valgrind.

See https://bugzilla.redhat.com/show_bug.cgi?id=588941#c39

Version-Release number of selected component (if applicable):
pypy-1.4.1-3.fc15.x86_64


How reproducible:
100%

Steps to Reproduce:
$ valgrind --track-origins=yes --leak-check=full ./pypy --jit threshold=-1 -c "pass"
  
Actual results:
Numerous warnings from valgrind; see e.g. attachment 469463 [details]

Expected results:
Should be "clean": no valgrind warnings.

Additional info:
May be x86_64 specific.  IIRC, also seen by Alex Gaynor on Ubuntu builds, so we may well need to take this upstream.

Comment 1 Maciej Fijalkowski 2011-01-04 09:51:53 UTC
PyPy has it's own GC that does nasty tricks sometime. We included valgrind support precisely for callgrind, not for valgrind itself. Since PyPy is written in a high-level garbage-collected language itself (there are no random memory corruption bugs, except when dealing with C or in GC code or assembler generation), I think spending time on valgrind warnings is pointless.

That said, not even all assembler generated by pypy is a valid assembler (there is a neat trick that expands code from compressed version when needed, mutating on the fly).

Cheers,
fijal

Comment 2 Fedora End Of Life 2013-04-03 18:32:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 3 Fedora Admin XMLRPC Client 2013-05-10 12:58:39 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 4 Fedora End Of Life 2015-01-09 16:30:08 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-02-17 13:33:41 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.