Bug 668001 (nepomukcontroller) - Review Request: nepomukcontroller - Applet to control the Nepomuk file indexer
Summary: Review Request: nepomukcontroller - Applet to control the Nepomuk file indexer
Keywords:
Status: CLOSED RAWHIDE
Alias: nepomukcontroller
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-07 16:13 UTC by Jaroslav Reznik
Modified: 2011-12-08 18:19 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-18 14:48:45 UTC
rdieter: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Jaroslav Reznik 2011-01-07 16:13:25 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/nepomukcontroller/nepomukcontroller.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/nepomukcontroller/nepomukcontroller-0.2-1.fc14.src.rpm
Description: Nepomukcontroller is a small systray applet that allows you to 
suspend and resume the Nepomuk file indexer.

Comment 1 Jaroslav Reznik 2011-01-07 16:17:26 UTC
This package is temporary solution as nepomukcontroller is going back to the kdebase-workspace package when 4.7 is released. The question is - do we want standalone package or incorporate it to kdebase-workspace package? Please, comment.

Comment 2 Jaroslav Reznik 2011-01-07 16:20:24 UTC
rpmlint nepomukcontroller-0.2-1.fc15.x86_64.rpm 
nepomukcontroller.x86_64: W: spelling-error %description -l en_US systray -> syst ray, syst-ray, systaltic
nepomukcontroller.x86_64: W: no-documentation
nepomukcontroller.x86_64: W: no-manual-page-for-binary nepomukcontroller
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


rpmlint nepomukcontroller-0.2-1.fc14.src.rpm 
nepomukcontroller.src: W: spelling-error %description -l en_US systray -> syst ray, syst-ray, systaltic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2707207

Comment 3 Rex Dieter 2011-01-14 15:28:50 UTC
naming: ok

macros: ok

sources: ok
7573bc8096f2c211342b745022a7ccdc  137088-nepomukcontroller-0.2.tar.bz2

scratch build: ok

rpmlint: ok

licensing: not ok.  It appears systray.h and systray.cpp are LGPLv2 only

I won't consider the small licensing thing a review-blocker, but please do address it prior to doing any builds.


otherwise, fairly small and simple,
APPROVED.

Comment 4 Jaroslav Reznik 2011-01-14 15:36:49 UTC
New Package SCM Request
=======================
Package Name: nepomukcontroller
Short Description: Applet to control the Nepomuk file indexer
Owners: jreznik rdieter than ltinkl thomasj kkofler
Branches: 
InitialCC:

Comment 5 Jason Tibbitts 2011-01-14 17:18:29 UTC
Git done (by process-git-requests).

Comment 6 Jaroslav Reznik 2011-01-18 12:25:29 UTC
Package Change Request
======================
Package Name: nepomukcontroller
New Branches: F14
Owners: jreznik rdieter than ltinkl thomasj kkofler

Fedpkg does not work with master branch only, so askin for F-14 one too. Please check https://bugzilla.redhat.com/show_bug.cgi?id=619979

Comment 7 Jason Tibbitts 2011-01-18 13:59:08 UTC
Git done (by process-git-requests).

Comment 8 Jaroslav Reznik 2011-01-18 14:48:45 UTC
Thanks,
build done for Rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=2728667 - closing now.


Note You need to log in before you can comment on or make changes to this bug.