Bug 669939 - Review Request: mediawiki116-ParserFunctions - Enhances the Mediawiki parser with logical functions
Summary: Review Request: mediawiki116-ParserFunctions - Enhances the Mediawiki parser ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jon Stanley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-INFRA-MW116
TreeView+ depends on / blocked
 
Reported: 2011-01-16 00:40 UTC by Ian Weller
Modified: 2012-05-21 22:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-21 22:21:08 UTC
Type: ---
Embargoed:
jonstanley: fedora-review+
notting: fedora-cvs+


Attachments (Terms of Use)

Description Ian Weller 2011-01-16 00:40:24 UTC
Spec URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki116-ParserFunctions/1.3.0-1.20110115svn80406/mediawiki116-ParserFunctions.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/mediawiki116-ParserFunctions/1.3.0-1.20110115svn80406/mediawiki116-ParserFunctions-1.3.0-1.20110115svn80406.fc14.src.rpm

Description:
ParserFunctions extension enhances parser with logical functions. For
instructions on how to use it, please see
http://meta.wikimedia.org/wiki/Help:ParserFunctions.

This extension is being used on one or more of Wikimedia's wikis. It means that
the extension is stable and works well enough to be used by such high traffic
websites.

Comment 1 Jon Stanley 2011-02-01 05:24:48 UTC
This package generally looks fine to me. A few nits:

* License tag is GPLv2+ - upstream is absolutely insane and says on their website that the code is licensed under "GPL2 or any OSI approved license". This cannot possibly be true, as it uses MediaWiki API's. Looking in the COPYING file included in Subversion, however, this provision isn't in there - it's a copy of GPLv2 with a note that the extension may be distributed under the GNU General Public License:

The ParserFunctions extension may be copied and redistributed under the GNU 
General Public License.

So this in the source control would make sense, except that this cannot possibly be GPL+ either (which this language would indicate). In the end, I think that the license tag of GPL2 would probably work, as this is the only possible license that one could use this under.

* Sources match upstream
* License file is in package
* Clean buildroot
* Checkout instructions from upstream SCM included
* Rpmlint clean

With the license tag change, this package is APPROVED.

Comment 2 Ian Weller 2011-02-01 16:50:05 UTC
New Package SCM Request
=======================
Package Name: mediawiki116-ParserFunctions
Short Description: Enhances the MediaWiki parser with logical functions
Owners: ianweller
Branches: el4 el5 el6
InitialCC:

Comment 3 Bill Nottingham 2011-02-02 22:35:56 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.