Hide Forgot
Hi, spmStart should check that the master storage domain is active diff --git a/vdsm/storage/spm.py b/vdsm/storage/spm.py index 904f532..a517f15 100644 --- a/vdsm/storage/spm.py +++ b/vdsm/storage/spm.py @@ -381,8 +381,13 @@ class SPM: pool = hsm.HSM.getPool(spUUID) pool.refreshDomains() masterDom = pool.getMasterDomain() + domList = pool.getDomains() oldlver = pool.getMetaParam(sd.LVER, cache=False) oldid = pool.getMetaParam(sd.SPM_ID, cache=False) + msdUUID = masterDom.sdUUID + + if domList[msdUUID] != sd.DOM_ACTIVE_STATUS: + raise se.StorageDomainNotActive(msdUUID) if int(oldlver) != int(prevLVER) or int(oldid) != int(prevID): raise se.SpmParamsMismatch(oldlver, oldid, prevLVER, prevID) Thanks, Vladik
This will break pool creation process (cannot activate master domain for first time before spm is available). "FIXING" this will be a bug.