Bug 672749 - Update vnc password failed for live domain in virt-manager
Summary: Update vnc password failed for live domain in virt-manager
Keywords:
Status: CLOSED DUPLICATE of bug 689372
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virt-manager
Version: 6.1
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-26 08:35 UTC by Min Zhan
Modified: 2011-05-19 02:23 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-07 17:09:42 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Min Zhan 2011-01-26 08:35:48 UTC
Description of problem:
Update VNC password for a running guest failed in virt-manager

Version-Release number of selected component (if applicable):
# uname -a
Linux dhcp-65-85.nay.redhat.com 2.6.32-99.el6.x86_64 #1 SMP Fri Jan 14 10:46:00
EST 2011 x86_64 x86_64 x86_64 GNU/Linux

kernel-2.6.32-99.el6.x86_64
qemu-kvm-0.12.1.2-2.129.el6.x86_64
libvirt-0.8.7-1.el6.x86_64
virt-manager-0.8.6-1.el6

How reproducible:
Always

Steps to Reproduce:
1.Run a guest successfully with vnc password is "aabb"
2.Open guest details page, click Display VNC, Modify the vnc password as "ccdd", Apply

  
Actual results:
A message display: Some changes may require a guest reboot to take effect

Expected results:
The vnc password can be changed on the fly

Additional info:

Comment 1 Cole Robinson 2011-02-22 20:55:45 UTC
Actually it looks like VNC pass is successfully changed, it's just that the message is misleading because the user may have also changed the keymap which cannot be hotplugged.

Please verify that VNC password change does work. We can use this bug to track getting the warning right only if keymap was changed.

Comment 2 Min Zhan 2011-02-23 02:53:54 UTC
(In reply to comment #1)

According to steps below, i think the vnc password actually changes. 

Steps:
1.Run a guest successfully with vnc password is "aabb"
2.Open guest details page, click Display VNC, Modify the vnc password as
"ccdd", Apply, then A message display: Some changes may require a guest reboot to take effect.
3.Use virt-viewer to check the vnc password is changed or not, found it is actually changed as "ccdd".


Additional info:

# virsh dumpxml <guest>
...
  <graphics type='vnc' port='5900' autoport='yes'/>
...

# tail -f /root/.virt-manager/virt-manager.log
...
[Wed, 23 Feb 2011 18:55:34 virt-manager 13610] DEBUG (engine:952) Starting vm 'r6'.
[Wed, 23 Feb 2011 18:55:34 virt-manager 13610] DEBUG (console:921) Starting connect process for proto=vnc trans=None connhost=localhost connuser=None connport=None gaddr=127.0.0.1 gport=5900 gsocket=None
[Wed, 23 Feb 2011 18:55:34 virt-manager 13610] DEBUG (manager:720) VM r6 started
[Wed, 23 Feb 2011 18:55:34 virt-manager 13610] DEBUG (console:307) Got credential request <enum VNC_DISPLAY_CREDENTIAL_PASSWORD of type VncDisplayCredential>
[Wed, 23 Feb 2011 18:55:37 virt-manager 13610] DEBUG (console:829) Viewer connected
[Wed, 23 Feb 2011 18:55:47 virt-manager 13610] DEBUG (libvirtobject:140) Redefining 'r6' with XML diff:
--- Original XML
+++ New XML
@@ -47,7 +47,7 @@
     </console>
     <input type="tablet" bus="usb"/>
     <input type="mouse" bus="ps2"/>
-    <graphics type="vnc" port="-1" autoport="yes" passwd="aabb"/>
+    <graphics type="vnc" port="-1" autoport="yes" passwd="ccdd"/>
     <sound model="ac97">
       <address type="pci" domain="0x0000" bus="0x00" slot="0x04" function="0x0"/>
    </sound>

[Wed, 23 Feb 2011 18:55:47 virt-manager 13610] DEBUG (error:66) dialog message: Some changes may require a guest reboot to take effect. :

Comment 3 Cole Robinson 2011-04-07 17:09:42 UTC
Duping this bug to the one that more accurately describes what we should be fixing

*** This bug has been marked as a duplicate of bug 689372 ***


Note You need to log in before you can comment on or make changes to this bug.