Bug 674551 - Invalid patch for I420 support breaks openchrome playback of mpeg in vlc
Summary: Invalid patch for I420 support breaks openchrome playback of mpeg in vlc
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-drv-openchrome
Version: 14
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Xavier Bachelot
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-02 13:29 UTC by Greg Farrell
Modified: 2012-08-16 22:37 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-16 22:37:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
updated patch (11.24 KB, patch)
2011-03-03 21:58 UTC, Xavier Bachelot
no flags Details | Diff

Description Greg Farrell 2011-02-02 13:29:39 UTC
Description of problem:
The patch openchrome-0.2.904-I420_Xv_surface_for_CME.patch attempts to add I420 support to Openchrome.

It is incomplete, viaQueryImageAttributes is lacking a case statement to correctly calculate the pitches and offsets for I420. Hence it calculates the pitches/offsets in the default: section which assumes a single plane.

A single pitch/offset is returned to vlc, which then cores when trying to use the 2nd and 3rd pitches which should be there.


How reproducible:
100%

Steps to Reproduce:
1.Play mpeg2 video in vlc 1.1.4 on fedora 14
2.Core

  
Actual results:


Expected results:


Additional info:
Adding case FOURCC_I420: above case FOURCC_YV12: in viaQueryImageAttributes allows I420 playback with incorrect colour - as U and V planes are obviously reversed. This shows that I420 should be treated as a 3 planar mode similar to YV12 - they are the same except U and V are reversed.

THis also shows that the rest of the code for I420 support is correctly working, it just needs to correctly determine pitch and offset.

Comment 1 Xavier Bachelot 2011-03-03 21:58:53 UTC
Created attachment 482167 [details]
updated patch

Comment 2 Xavier Bachelot 2011-03-03 21:59:59 UTC
Does that help if you replace the original patch with the one attached to this bug ?

Comment 3 Fedora Update System 2011-05-09 12:30:56 UTC
xorg-x11-drv-openchrome-0.2.904-14.fc15.1 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xorg-x11-drv-openchrome-0.2.904-14.fc15.1

Comment 4 Fedora Update System 2011-05-09 22:38:26 UTC
Package xorg-x11-drv-openchrome-0.2.904-14.fc15.1:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xorg-x11-drv-openchrome-0.2.904-14.fc15.1'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/xorg-x11-drv-openchrome-0.2.904-14.fc15.1
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2011-06-08 23:18:37 UTC
xorg-x11-drv-openchrome-0.2.904-8.fc14.2 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xorg-x11-drv-openchrome-0.2.904-8.fc14.2

Comment 6 Fedora Update System 2012-02-10 21:58:04 UTC
xorg-x11-drv-openchrome-0.2.905-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xorg-x11-drv-openchrome-0.2.905-1.fc15

Comment 7 Fedora Update System 2012-02-10 21:58:22 UTC
xorg-x11-drv-openchrome-0.2.905-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/xorg-x11-drv-openchrome-0.2.905-1.fc16

Comment 8 Fedora End Of Life 2012-08-16 22:37:37 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.