Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Hash-MoreUtils.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Hash-MoreUtils-0.02-1.fc15.src.rpm Description: Similar to List::MoreUtils, Hash::MoreUtils contains trivial but commonly- used functionality for hashes.
As I mentioned in bug #675529, I really wouldn't bother with using Test-CheckManifest. It only adds additional build-time complexity without providing any meaningful test coverage. I would much rather see this packaged in the normal way and simply skip t/manifest.t.
(In reply to comment #1) > As I mentioned in bug #675529, I really wouldn't bother with using > Test-CheckManifest. It only adds additional build-time complexity without > providing any meaningful test coverage. Agreed. However, the origin of this issue is a malfunction of rpm (polluting build-directories) - It's a general issue with rpm and affects many packages, not only perl-modules using Test-CheckManifest > I would much rather see this packaged > in the normal way and simply skip t/manifest.t. I prefer exercising all of a package's testsuites and prefer to avoid modifying a package to make it buildable with rpm.
+ source files match upstream. 07350a6b0813fbe88b8b48ef786dda98 Hash-MoreUtils-0.02.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2883410 + package installs properly. + rpmlint has no meaningful complaints: perl-Hash-MoreUtils.noarch: W: spelling-error Summary(en_US) Util -> Til, U til, Utile perl-Hash-MoreUtils.src: W: spelling-error Summary(en_US) Util -> Til, U til, Utile 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + final provides and requires are sane: perl(Hash::MoreUtils) = 0.02 perl-Hash-MoreUtils = 0.02-1.fc16 = perl(:MODULE_COMPAT_5.12.3) perl(Exporter) perl(Scalar::Util) perl(strict) perl(vars) perl(warnings) + %check is present and all tests pass. # Testing Hash::MoreUtils 0.02, Perl 5.012003, /usr/bin/perl t/00-load.t ....... ok t/01-hash.t ....... ok t/manifest.t ...... ok t/pod-coverage.t .. ok t/pod.t ........... ok All tests successful. Files=5, Tests=18, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.18 cusr 0.02 csys = 0.23 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Despite disagreeing with you over t/manifest.t, it's your package and there's certainly nothing in the guidelines that says you mustn't jump through hoops to run "release" tests; just that you don't need to enable them. APPROVED.
Thanks once again, Iain. New Package SCM Request ======================= Package Name: perl-Hash-MoreUtils Short Description: Provide the stuff missing in Hash::Util Owners: corsepiu Branches: f13 f14 f15 InitialCC: perl-sig
Git done (by process-git-requests).
This was imported and built for all branches back in March.