Hide Forgot
Description of problem: The network test uses ping -f, producing period characters and back-spaces to indicate progress, but this has no value in test logs. The network test should run ping with less-verbose options.
I suggest we change the use of ping to use the -q option. This changes the logged output to be: PING gnichols.usersys.redhat.com (10.16.47.158) 56(84) bytes of data. --- gnichols.usersys.redhat.com ping statistics --- 1000 packets transmitted, 1000 received, 0% packet loss, time 250ms rtt min/avg/max/mdev = 0.217/0.230/0.429/0.012 ms, ipg/ewma 0.250/0.230 ms PING gnichols.usersys.redhat.com (10.16.47.158) 1(29) bytes of data. repeated for each size option.
We should do some packet drop runs as well to see how visible that is. If the -f option makes them more clear we may want to keep it, otherwise though, works for me.
Created attachment 479385 [details] network test patch with -q on ping for quieter output This patch also adds warnings for packet loss. Note the array constant on line 341, which allows a warning threshold to be set for each packet size.
Example output with above patch (note: margin lowered to 10% to show warning). [...] --- gnichols.usersys.redhat.com ping statistics --- 1000 packets transmitted, 1000 received, 0% packet loss, time 2249ms rtt min/avg/max/mdev = 2.141/2.195/2.479/0.036 ms, ipg/ewma 2.252/2.194 ms /bin/ping -i 0 -q -c 1000 -s 40000 gnichols.usersys.redhat.com PING gnichols.usersys.redhat.com (10.16.47.158) 40000(40028) bytes of data. --- gnichols.usersys.redhat.com ping statistics --- 1000 packets transmitted, 165 received, 83% packet loss, time 10872ms rtt min/avg/max/mdev = 7.300/7.353/7.549/0.085 ms, ipg/ewma 10.882/7.345 ms Warning: packet loss of 83% is greater than 10% expected /bin/ping -i 0 -q -c 1000 -s 65507 gnichols.usersys.redhat.com PING gnichols.usersys.redhat.com (10.16.47.158) 65507(65535) bytes of data. --- gnichols.usersys.redhat.com ping statistics ---1000 packets transmitted, 0 received, 100% packet loss, time 21465ms Error: "/bin/ping -i 0 -q -c 1000 -s 65507 gnichols.usersys.redhat.com" returned 1 FAIL
Question: what are "good" margin settings for each packet size?
Created attachment 488804 [details] network test patch changing icmp test to try 5 times max at 5000 count
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: A new enhancement has been made in v7 1.3 that network test ICMP/ping test is improved to produce less verbose output in flood-ping mode and 5 re-tries on fail is allowed.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0497.html