Hide Forgot
---Problem Description--- As discussed with Chris Wright via email, I am opening this report to include any bugfixes for IEEE 802.1Qbg support in lldpad into RHEL6.1 that are found during testing with RHEL6.1 pre- releases. ---uname output--- Linux c7b2 2.6.32-71.el6.x86_64 #1 SMP Wed Sep 1 01:33:01 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux Machine Type = IBM HS22 blade server ---Steps to Reproduce--- upgrade to latest lldpad upstream test IEEE 802.1Qbg with lldpad ---System Management Component Data--- Userspace tool common name: lldpad System management type: kvm The userspace tool has the following bit modes: 64-bit Userspace rpm: lldpad A set of bugfixes has been submitted to the lldpad development mailing list on 2/3 and have been accepted upstream on 2/8: 1d74721 robustness: proper handling of LINK_DOWN/UP 5b74605 new: call VDP station state machine on demand 6bcb3c3 new: change VDP ACK timer value 426a50e new: change the ECP ack timer from RTE based to fixed e698bc3 cleanup: change request from mode to boolean 22d4dd6 bugfix: state ECP_TX_IDLE no longer exists 8ee44ed bugfix: set configured capabilities as well a2b1745 new: rework of VDP code towards newer drafts regards, Jens Osterkamp <jens.com>
Created attachment 481906 [details] lldpad-bugfixes-1.tar.bz2
Created attachment 481908 [details] lldpad-bugfixes-2.tar.bz2
=== In Red Hat Customer Portal Case 00419255 === --- Comment by IBM bug, proxy on 3/2/2011 9:42 AM --- ------- Comment From jens.com 2011-03-02 09:36 EDT------- (In reply to comment #1) > A set of bugfixes has been submitted to the lldpad development mailing list on > 2/3 and have been accepted upstream on 2/8: > > 1d74721 robustness: proper handling of LINK_DOWN/UP > 5b74605 new: call VDP station state machine on demand > 6bcb3c3 new: change VDP ACK timer value > 426a50e new: change the ECP ack timer from RTE based to fixed > e698bc3 cleanup: change request from mode to boolean > 22d4dd6 bugfix: state ECP_TX_IDLE no longer exists > 8ee44ed bugfix: set configured capabilities as well > a2b1745 new: rework of VDP code towards newer drafts attached a tar ball for this first set of patches (lldpad-bugfixes-1.tar.bz2). ------- Comment From jens.com 2011-03-02 09:38 EDT------- A second set of bugfixes has been submitted to the lldpad development mailing list on 2/28 : 93ab250 prevent "forgotten" ECP frame for vsi type (posting_mar2011) b4ba885 consolidate ecp_somethingChangedlocal 8bdf62c always flag changed profile in vdp_add_profile 862823d fix memory leak in vdp_indicate ee951ba generic: renamed find_module_user_data_by_if 1fd3130 check if port is enabled for RxTx 99f8ed0 rework ecp timer code towards newer drafts f0549ed be sure to stop timers on VSI_EXIT 705ca6c handle negative response in VDP state machine 5d108b3 cleanup: only print profiles that are removed 45c8f8e fix potential crash after link up f72834d no error if the profile already exists b8fb486 event if: always reject request if link is down attached a tar ball for the second set of patches (lldpad-bugfixes-2.tar.bz2).
=== In Red Hat Customer Portal Case 00419255 === --- Comment by Chavez, Luciano on 3/2/2011 12:28 PM --- Jens raised the severity on our Bugzilla bug. The justification for this was provided as: The vast majority of these patch fixes bugs around the sending of keepalives. Without these patches the Qbg support in RHEL will only work a few hours at best and no longer after a link down/up or a switch reboot. We will therefore definitely need them.
All attached patches applied in CVS lldpad-0.9.41-2.el6
According to errata-how-to-test (For 802.1Qbg -- SanityOnly) Closing as SanityOnly with reference to https://bugzilla.redhat.com/show_bug.cgi?id=630087#c25
=== In Red Hat Customer Portal Case 00419255 === --- Comment by IBM bug, proxy on 3/14/2011 12:50 PM --- ------- Comment From jens.com 2011-03-14 12:45 EDT------- The second set of bugfixes has been accepted upstream on 3/7 and is available from the upstream git git://open-lldp.org/lldp/open-lldp: 4749b5a prevent "forgotten" ECP frame for vsi type 713b589 consolidate ecp_somethingChangedlocal e63d883 always flag changed profile in vdp_add_profile bc2fec2 fix memory leak in vdp_indicate 52d9fd1 generic: renamed find_module_user_data_by_if 96b9a70 check if port is enabled for RxTx 1ce3f72 rework ecp timer code towards newer drafts 6a37540 be sure to stop timers on VSI_EXIT 2784f4b handle negative response in VDP state machine 47ea2f2 cleanup: only print profiles that are removed 9b6f5c8 fix potential crash after link up 44ce9bb no error if the profile already exists 17e3797 event if: always reject request if link is down
I'll also include commit 937d571370f2e2f2175d5910d2ca8a68a8d65920 (a minor README update) while syncing with upstream.
(In reply to comment #11) > I'll also include commit 937d571370f2e2f2175d5910d2ca8a68a8d65920 (a minor > README update) while syncing with upstream. lldpad-0.9.41-3.el6
=== In Red Hat Customer Portal Case 00419255 === --- Comment by IBM bug, proxy on 3/22/2011 9:32 AM --- ------- Comment From jens.com 2011-03-22 09:31 EDT------- I verified that all commits up to 52d9fd1 generic: renamed find_module_user_data_by_if are contained in lldpad-0.9.41-2.el6 which is in beta1 of RHEL6.1. Thanks ! 4749b5a prevent "forgotten" ECP frame for vsi type 713b589 consolidate ecp_somethingChangedlocal e63d883 always flag changed profile in vdp_add_profile bc2fec2 fix memory leak in vdp_indicate are not yet contained.
------- Comment From jens.com 2011-02-25 07:26 EDT------- (In reply to comment #6) > Hello, > I have sent this up for engineering to review. > Thank You > Joe Kachuck Thank you for passing this on ! I have a couple more fixes in the queue for lldpad which I am planning send out on the mailing list soon. I will add a comment here once they are out. > ------- Comment From tpnoonan.com 2011-03-09 10:49 EDT------- please consider as exception for rhel6.1
------- Comment From jens.com 2011-04-05 08:44 EDT------- I verified that all commits up to 52d9fd1 generic: renamed find_module_user_data_by_if are in lldpad-0.9.41-3.el6 which is in snapshot1 of RHEL6.1. Thanks ! 4749b5a prevent "forgotten" ECP frame for vsi type 713b589 consolidate ecp_somethingChangedlocal e63d883 always flag changed profile in vdp_add_profile bc2fec2 fix memory leak in vdp_indicate are not yet contained. In addition the patch "allow VSI sm state change from ASSOC to PREASSOC_P" is needed to prevent a crash of lldpad during migration. It has been found during testing and has been sent out on the open-lldp mailing list last week.
Upstream is currently 6 commits ahead of the latest 6.1 package. The last patch mentioned by Jens has not been accepted upstream yet. Unless IBM considers this a blocker, I'd suggest moving this and future requests to a new, 6.2 bug.
~~ Partners and Customers ~~ This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible. If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know. Thanks!
New patches have been added to the latest build, please test the next snapshot (lldpad-0.9.41-4.el6) and update us here with test results. Thanks.
------- Comment From jens.com 2011-04-27 15:11 EDT------- (In reply to comment #25) > New patches have been added to the latest build, please test the next snapshot > (lldpad-0.9.41-4.el6) and update us here with test results. Thanks. We verified that all upstream patches are in lldpad-0.9.41-4.el6. We have successfully tested it with snapshot 4 in our setup.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0520.html