Hide Forgot
In the start_instance() function in file pki/base/common/scripts/functions A loop was recently added to wait for the instance to fully initialize by using netstat to check socket availability. There are a couple of minor problems which need fixing. 1) No check for previous status The instance is started like this: $PKI_INSTANCE_INITSCRIPT start rv=$? then the loop is entered. But if the initscript failed ($rv -ne 0) there is no point in looping for 30 seconds waiting for it to come up. The function should immediately return the failed error code. 2) If the loop is exhausted and no sockets were detected the function should return a failure error code.
Created attachment 479632 [details] better netstat loop behaviour
TIP: # cd pki # svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^? M base/common/scripts/functions # svn commit Sending base/common/scripts/functions Transmitting file data . Committed revision 1861.