Bug 681628 - Unowned libexecdir/smartmontools and share/smartmontools dirs
Summary: Unowned libexecdir/smartmontools and share/smartmontools dirs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: smartmontools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-02 19:00 UTC by Ville Skyttä
Modified: 2011-03-03 15:18 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-03 11:07:56 UTC
Type: ---


Attachments (Terms of Use)
Own %{_datadir}/%{name} and %{_libexecdir}/%{name} dirs (1.14 KB, patch)
2011-03-02 19:00 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2011-03-02 19:00:46 UTC
Created attachment 481928 [details]
Own %{_datadir}/%{name} and %{_libexecdir}/%{name} dirs

Fix attached.  Ok to push+build for devel?

Comment 1 Michal Hlavinka 2011-03-03 11:07:56 UTC
Thanks for reporting this, I've fixed it using slightly different approach:
-%{_libexecdir}/%{name}/smartdnotify
-%{_datadir}/%{name}/drivedb.h
+%{_libexecdir}/%{name}
+%{_datadir}/%{name}

because it's not expected that any other package adds any file in those directories

Comment 2 Ville Skyttä 2011-03-03 15:18:07 UTC
Thanks, that's a perfectly valid approach, I just chose to add specific entries because the specfile already contained fairly specific %files listing.

BTW it's not relevant if another package chooses to install files to those dirs, it's just a matter of how closely you want to keep track of the files installed by smartmontools (for example in case new files appear or old ones disappear between versions etc or depending on the build flags).  %files entries like %{_sbindir}/* would not cause any non-smartmontools files to be included in the package in any sane package build environment.


Note You need to log in before you can comment on or make changes to this bug.