Bug 682423 - better handling for temporary CIFS writeback errors
Summary: better handling for temporary CIFS writeback errors
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jeff Layton
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-05 12:03 UTC by Jeff Layton
Modified: 2012-11-15 19:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-11-15 19:57:36 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Jeff Layton 2011-03-05 12:03:01 UTC 
Currently, when the CIFS code receives any error during writeback it will mark the page and mapping with an error and quit trying to write back. This is true even for temporary errors like EAGAIN during timeouts. I introduced a patch upstream to fix this a few months ago.

Opening this bug to consider backporting that for RHEL5.
Comment 1 Jeff Layton 2011-03-05 12:05:06 UTC 
The patch I'm considering is this one. I don't have a great reproducer for this, but I think it's something we should consider even for RHEL5:

commit 941b853d779de3298e39f1eb4e252984464eaea8
Author: Jeff Layton <jlayton>
Date:   Tue Jan 11 07:24:01 2011 -0500

    cifs: don't fail writepages on -EAGAIN errors
Comment 2 Jeff Layton 2012-11-15 19:54:45 UTC 
So far, I've not heard great hue and cry for this patch. At this point I think we're best off just closing this WONTFIX. We can revisit it later if there is need...
Comment 3 RHEL Program Management 2012-11-15 19:57:36 UTC 
Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.
Note You need to log in before you can comment on or make changes to this bug.