Hide Forgot
Spec URL: http://fedorapeople.org/~grover/lio-utils.spec SRPM URL: http://fedorapeople.org/~grover/srpms/lio-utils-3.2-1.src.rpm Description: This package is used to control the new kernel-based target infrastructure that is present in 2.6.38+. It allows the admin to export scsi block devices (LUNs) via iSCSI, FCoE, and the like.
I've probably asked this before, but what's the way forward between this, scsi-target-utils, scst, etc?
LIO was accepted upstream over scst. Long-term, scsi-target-utils will be deprecated in favor of LIO. The exact timing and method of that transition is still TBD.
Some comments: a) no url tag, where is this project living? b) you might want to add the sha1 8ad98e3 to the tarball name? c) -n %{name}-%{version} in %setup is the default and can be dropped (however, consider b)) d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one. e) use macros for /etc, /sbin and /etc/init.d/ f) target is a very generic name, possible problem g) change %defattr(-,root,root) -> %defattr(-,root,root,-) h) the package seems to be free for docs and with no url tag, the user will have a hard time be able to use this utility. i) Release: 1, please add disttag here.
j) it builds in koji, however correct %{optflags} is not used: http://koji.fedoraproject.org/koji/getfile?taskID=2895139&name=build.log http://koji.fedoraproject.org/koji/taskinfo?taskID=2895138
(In reply to comment #3) > Some comments: > > a) no url tag, where is this project living? > b) you might want to add the sha1 8ad98e3 to the tarball name? > c) -n %{name}-%{version} in %setup is the default and can be dropped > (however, consider b)) I decided to keep the tarball name, since future releases should have proper tarballs. > d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one. > e) use macros for /etc, /sbin and /etc/init.d/ > f) target is a very generic name, possible problem True.. it's what upstream is using, so I'm hesitant to diverge. > g) change %defattr(-,root,root) -> %defattr(-,root,root,-) > h) the package seems to be free for docs and with no url tag, the user > will have a hard time be able to use this utility. Yeah, I'll be working with upstream to author some manpages. > i) Release: 1, please add disttag here. All the rest are done. Revised versions: http://fedorapeople.org/~grover/lio-utils.spec(2) http://fedorapeople.org/~grover/srpms/lio-utils-3.2-1.src.rpm
Whups, added optflags and made disttag conditional. http://fedorapeople.org/~grover/lio-utils.spec3 http://fedorapeople.org/~grover/srpms/lio-utils-3.2-3.el6.src.rpm
Would be simpler to follow if you add a real changelog.
This package has been superseded by targetcli, so I'm closing this one.